Issue 113857: Adds mouseover images to the close tab button on Mac....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113857: Adds mouseover images to the close tab button on Mac.... (Closed)

Created:
11 years, 7 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Adds mouseover images to the close tab button on Mac. BUG=none TEST=Mousing over the close button should change its image. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17417

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

		Unified diffs	Side-by-side diffs	Stats (+32 lines, -0 lines)
	M	chrome/browser/cocoa/tab_view.h	View	2 chunks	+5 lines, -0 lines	0 comments
	M	chrome/browser/cocoa/tab_view.mm	View	2 chunks	+27 lines, -0 lines	2 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

Nothing important, but I finally figured out why resizing tabs broke my mouseovers, so now ...

11 years, 7 months ago (2009-05-26 20:46:43 UTC) #1

pink (ping after 24hrs)

LGTM with question. http://codereview.chromium.org/113857/diff/1/3 File chrome/browser/cocoa/tab_view.mm (right): http://codereview.chromium.org/113857/diff/1/3#newcode29 Line 29: owner:self are you sure this ...

11 years, 7 months ago (2009-05-27 13:07:59 UTC) #2

rohitrao (ping after 24h)

11 years, 7 months ago (2009-05-27 23:58:50 UTC) #3

http://codereview.chromium.org/113857/diff/1/3
File chrome/browser/cocoa/tab_view.mm (right):

http://codereview.chromium.org/113857/diff/1/3#newcode29
Line 29: owner:self
On 2009/05/27 13:07:59, pink wrote:
> are you sure this doesn't set up an ownership cycle? Can you verify that
dealloc
> is still getting called on TabView?

I added logging in dealloc and verified that dealloc is getting called for every
tab.

More reassuringly, I also added logging in a retain method and verified that
TabView is not being retained by NSTrackingArea.

Expand Messages | Collapse Messages