Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 113839: Remove duplicate line in benchmarks/base.js ... (Closed)

Created:
11 years, 7 months ago by sandholm
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Remove duplicate line in benchmarks/base.js This resolves issue 356 (http://code.google.com/p/v8/issues/detail?id=356) thanks to bitRAKE. Changed benchmark version number from 4 to 5 resulting in updates to base.js, README.txt and revisions.html. Committed: http://code.google.com/p/v8/source/detail?r=2058

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M benchmarks/README.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M benchmarks/base.js View 1 2 chunks +1 line, -2 lines 0 comments Download
M benchmarks/revisions.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sandholm
11 years, 7 months ago (2009-05-26 12:40:31 UTC) #1
Erik Corry
LGTM
11 years, 7 months ago (2009-05-26 12:44:57 UTC) #2
sandholm
11 years, 7 months ago (2009-05-26 13:04:22 UTC) #3
Erik Corry
If you also update revisions.html then it L even better TM.
11 years, 7 months ago (2009-05-26 13:08:37 UTC) #4
sandholm
11 years, 7 months ago (2009-05-26 13:17:57 UTC) #5
Erik Corry
11 years, 7 months ago (2009-05-26 13:20:31 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698