Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 113838: Fix for issue 351 - lastIndexOf. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix for issue 351 - lastIndexOf. Committed: http://code.google.com/p/v8/source/details?r=2060

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added more tests, as requested. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -24 lines) Patch
M src/string.js View 1 1 chunk +17 lines, -11 lines 0 comments Download
A test/mjsunit/regress/regress-351.js View 1 chunk +31 lines, -0 lines 0 comments Download
M test/mjsunit/string-lastindexof.js View 1 1 chunk +50 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
Quick review.
11 years, 7 months ago (2009-05-26 11:58:42 UTC) #1
Erik Corry
LGTM http://codereview.chromium.org/113838/diff/1/3 File test/mjsunit/regress/regress-351.js (right): http://codereview.chromium.org/113838/diff/1/3#newcode31 Line 31: assertEquals(0, "test".lastIndexOf("test", -1)); Please add case with ...
11 years, 7 months ago (2009-05-26 12:12:26 UTC) #2
Lasse Reichstein
11 years, 7 months ago (2009-05-26 15:41:10 UTC) #3
http://codereview.chromium.org/113838/diff/1/3
File test/mjsunit/regress/regress-351.js (right):

http://codereview.chromium.org/113838/diff/1/3#newcode31
Line 31: assertEquals(0, "test".lastIndexOf("test", -1));
Added to string-lastindexof.js.

Powered by Google App Engine
This is Rietveld 408576698