Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: webkit/glue/webview_impl.cc

Issue 113836: DevTools: introduce bound object on the agent side. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webframeloaderclient_impl.cc ('k') | webkit/webkit.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webview_impl.cc
===================================================================
--- webkit/glue/webview_impl.cc (revision 16977)
+++ webkit/glue/webview_impl.cc (working copy)
@@ -906,7 +906,6 @@
// Do this first to prevent reentrant notifications from being sent to the
// initiator of the close.
delegate_ = NULL;
- devtools_agent_.reset(NULL);
if (page_.get()) {
// Initiate shutdown for the entire frameset. This will cause a lot of
@@ -915,6 +914,9 @@
page_->mainFrame()->loader()->frameDetached();
page_.reset();
}
+
+ // Should happen after page_.reset().
+ devtools_agent_.reset(NULL);
Release(); // Balances AddRef from WebView::Create
}
« no previous file with comments | « webkit/glue/webframeloaderclient_impl.cc ('k') | webkit/webkit.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698