Issue 113823: Added support for constructor calls in the NPAPI

Issue 113823: Added support for constructor calls in the NPAPI (Closed)

Created:
11 years, 7 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe, Mads Ager (chromium)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added support for constructor calls in the NPAPI. The LiveConnect test cases at http://java.sun.com/javase/6/webnotes/6u10/plugin2/liveconnect/LiveConnectTests/ now pass for Chromium. Parts of this change is rather mechanical, and leaves room for some refactoring afterwards. Merged the implementation of testConstruct and the "objectPointer" property from WebKit\WebKitTools\DumpRenderTree\TestNetscapePlugIn.subproj\TestObject.cpp to the Chromium TestObject.cpp for the layout test LayoutTests\plugins\netscape-construct.html pass. BUG=http://crbug.com/3285 BUG=http://crbug.com/10354 TEST=http://java.sun.com/javase/6/webnotes/6u10/plugin2/liveconnect/LiveConnectTests/ TEST=LayoutTests\plugins\netscape-construct.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16979

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+200 lines, -25 lines)			Patch
M	chrome/common/plugin_messages_internal.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/plugin/npobject_proxy.h	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/plugin/npobject_proxy.cc	View	1	3 chunks	+47 lines, -2 lines	0 comments	Download
M	chrome/plugin/npobject_stub.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/plugin/npobject_stub.cc	View	1	2 chunks	+40 lines, -0 lines	0 comments	Download
M	webkit/port/bindings/v8/NPV8Object.cpp	View	1	1 chunk	+33 lines, -3 lines	0 comments	Download
M	webkit/port/bindings/v8/V8NPObject.cpp	View	1	3 chunks	+10 lines, -9 lines	0 comments	Download
M	webkit/port/bindings/v8/v8_proxy.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/port/bindings/v8/v8_proxy.cpp	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/npapi_layout_test_plugin/TestObject.cpp	View	1 2	4 chunks	+29 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/113823/diff/1/11 File chrome/plugin/npobject_proxy.cc (right): http://codereview.chromium.org/113823/diff/1/11#newcode369 Line 369: // See somment in NPObjectProxy::NPInvokePrivate. somment -> ...

11 years, 7 months ago (2009-05-25 17:28:08 UTC) #2

Søren Thygesen Gjesse

11 years, 7 months ago (2009-05-27 08:48:09 UTC) #3

http://codereview.chromium.org/113823/diff/1/11
File chrome/plugin/npobject_proxy.cc (right):

http://codereview.chromium.org/113823/diff/1/11#newcode369
Line 369: // See somment in NPObjectProxy::NPInvokePrivate.
On 2009/05/25 17:28:08, Mads Ager wrote:
> somment -> comment

Done.

http://codereview.chromium.org/113823/diff/1/7
File webkit/tools/npapi_layout_test_plugin/TestObject.cpp (right):

http://codereview.chromium.org/113823/diff/1/7#newcode69
Line 69: #define NUM_ENUMERATABLE_TEST_IDENTIFIERS 4
On 2009/05/25 17:28:08, Mads Ager wrote:
> ENUMERATABLE -> ENUMERABLE

Done (the code in
WebKit\WebKitTools\DumpRenderTree\TestNetscapePlugIn.subproj\TestObject.cpp uses
ENUMERATABLE though).

Expand Messages | Collapse Messages