- Introduce histograms collecting data about the number of set remembered set...

- Introduce histograms collecting data about the number of set remembered set
  bits in a page.

Committed: http://code.google.com/p/v8/source/detail?r=2045

[Kevin Millikin (Chromium), 2009-05-25 12:09:17]

See comment below.  If this is what we intend, then the comment in the header
should change to reflect it.

http://codereview.chromium.org/113819/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/113819/diff/1/2#newcode2696
Line 2696: set_bits_count++;
Here this is counting the rset words (uint32s) that have at least one bit set. 
To count bits, the increment should be moved inside the if in the inner (for)
loop.

[iposva, 2009-05-25 14:03:47]

Updated...

On 2009/05/25 12:09:17, Kevin Millikin wrote:
> See comment below.  If this is what we intend, then the comment in the header
> should change to reflect it.
> 
> http://codereview.chromium.org/113819/diff/1/2
> File src/heap.cc (right):
> 
> http://codereview.chromium.org/113819/diff/1/2#newcode2696
> Line 2696: set_bits_count++;
> Here this is counting the rset words (uint32s) that have at least one bit set.

> To count bits, the increment should be moved inside the if in the inner (for)
> loop.

[Kevin Millikin (Chromium), 2009-05-25 14:15:16]

LGTM.