Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1138004: Add multithreading test for SamplingCircularQueue, fix implementation. (Closed)

Created:
10 years, 9 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add multithreading test for SamplingCircularQueue, fix implementation. This is for the case of Linux, where sampling is done using SIGPROF signal handler which is executed in the context of an interrupted thread. In this case, my previous implementation with TLS doesn't work. Committed: http://code.google.com/p/v8/source/detail?r=4207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -78 lines) Patch
M src/circular-queue.h View 4 chunks +6 lines, -9 lines 0 comments Download
M src/circular-queue.cc View 2 chunks +37 lines, -49 lines 0 comments Download
M src/circular-queue-inl.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/cpu-profiler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/cpu-profiler.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-circular-queue.cc View 2 chunks +98 lines, -4 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 9 months ago (2010-03-22 12:58:59 UTC) #1
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-22 14:12:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698