cc: Add PictureLayerTiling for impl-side painting

cc: Add PictureLayerTiling for impl-side painting

This adds an interface for generating/iterating/creating tiles and tilings.
PictureLayerImpl now knows a lot less about the internals of the tiling (yay).

TBR=nduca@chromium.org
BUG=155209
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167997

[commit-bot: I haz the power, 2012-11-15 01:43:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/11377176/1

[tfarina, 2012-11-15 01:49:28]

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tiling.h
File cc/picture_layer_tiling.h (right):

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:1: // Copyright 2011 The Chromium Authors. All rights
reserved.
2011 -> 2012?

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:4: 
rm extra blank line.

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:37: void set_bounds(const gfx::Size&);
SetBounds

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:40: void create_tiles(gfx::Rect);
we use to name the parameters in chromium

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:40: void create_tiles(gfx::Rect);
if you don't inline on the header file, i.e, if the function is not trivial,
then you should not use unix_hacker style for naming it, instead use CamelCase.

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:45: Iterator(PictureLayerTiling* tiling_, gfx::Rect
content_rect);
trailing _ in tiling_

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:76: friend class PictureLayerTiling;
this goes at the beginning of the section.

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:87: PictureLayerTiling(const gfx::Size& tileSize);
I though James and Dana wanted to pass small struct by value.

So confusing and inconsistent :/

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:90: PictureLayerTilingClient* client_;
data member variables should be private

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:94: friend class Iterator;
this goes at the beginning of the section.

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_tilin...
cc/picture_layer_tiling.h:95: };
DISALLOW_CO...?

[tfarina, 2012-11-15 01:54:04]

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_impl.h
File cc/picture_layer_impl.h (right):

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_impl....
cc/picture_layer_impl.h:19: public PictureLayerTilingClient {
nit: no, no no :)

class FOO_EXPORT Foo : public BarImpl,
                       public FDelegate {
                       ^ align here
};

or

class FOO_EXPORT Foo
    : public VeryLongClassNameImpl,
      public AnotherVeryVeryLongClassNameImpl {
};

https://chromiumcodereview.appspot.com/11377176/diff/1/cc/picture_layer_impl....
cc/picture_layer_impl.h:33: virtual scoped_refptr<Tile>
CreateTile(PictureLayerTiling*,
you could have made this private instead.

[nduca, 2012-11-15 02:19:05]

lgtm as a checkpoint

http://codereview.chromium.org/11377176/diff/1/cc/picture_layer_tiling.h
File cc/picture_layer_tiling.h (right):

http://codereview.chromium.org/11377176/diff/1/cc/picture_layer_tiling.h#newc...
cc/picture_layer_tiling.h:28: class CC_EXPORT PictureLayerTiling {
I think this object probably needs to manage multiple tilings

[nduca, 2012-11-15 02:19:37]

@tfarina, we're in quick prototype mode, best to confine feedback to structural
comments.

[commit-bot: I haz the power, 2012-11-15 02:31:19]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-15 17:54:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/11377176/14001

[commit-bot: I haz the power, 2012-11-15 19:57:05]

Change committed as 167997