Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: chrome/renderer/resources/extensions/web_view.js

Issue 11377089: browser-plugin: Send a JSON string for the detail data with the events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/renderer/browser_plugin/browser_plugin.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Shim that simulates a <webview> tag via Mutation Observers. 5 // Shim that simulates a <webview> tag via Mutation Observers.
6 // 6 //
7 // The actual tag is implemented via the browser plugin. The internals of this 7 // The actual tag is implemented via the browser plugin. The internals of this
8 // are hidden via Shadow DOM. 8 // are hidden via Shadow DOM.
9 9
10 var WEB_VIEW_ATTRIBUTES = ['src']; 10 var WEB_VIEW_ATTRIBUTES = ['src'];
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 attributeName, this.node_.getAttribute(attributeName)); 150 attributeName, this.node_.getAttribute(attributeName));
151 }; 151 };
152 152
153 /** 153 /**
154 * @private 154 * @private
155 */ 155 */
156 WebView.prototype.setupEvent_ = function(eventname, attribs) { 156 WebView.prototype.setupEvent_ = function(eventname, attribs) {
157 var node = this.node_; 157 var node = this.node_;
158 this.objectNode_.addEventListener('-internal-' + eventname, function(e) { 158 this.objectNode_.addEventListener('-internal-' + eventname, function(e) {
159 var evt = new Event(eventname); 159 var evt = new Event(eventname);
160 var detail = e.detail ? JSON.parse(e.detail) : {};
160 attribs.forEach(function(attribname) { 161 attribs.forEach(function(attribname) {
161 evt[attribname] = e.detail[attribname]; 162 evt[attribname] = detail[attribname];
162 }); 163 });
163 node.dispatchEvent(evt); 164 node.dispatchEvent(evt);
164 }); 165 });
165 } 166 }
OLDNEW
« no previous file with comments | « no previous file | content/renderer/browser_plugin/browser_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698