Issue 11377089: browser-plugin: Send a JSON string for the detail data with the events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11377089: browser-plugin: Send a JSON string for the detail data with the events. (Closed)

Created:
8 years, 1 month ago by sadrul

Modified:
8 years, 1 month ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, Aaron Boodman, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, Fady Samuel, lazyboy

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

browser-plugin: Send a JSON string for the detail data with the events. BUG=155044

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -25 lines)			Patch
M	chrome/renderer/resources/extensions/web_view.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin.cc	View	4 chunks	+11 lines, -11 lines	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin_browsertest.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	content/test/data/browser_plugin_embedder.html	View	2 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

Hi Adam. I tried creating a WebSerializedScriptValue directly from base::Value, but it looks like the ...

8 years, 1 month ago (2012-11-09 23:34:37 UTC) #1

abarth-chromium

Yes, this looks great! Thanks for iterating on the approach! LGTM

8 years, 1 month ago (2012-11-09 23:39:05 UTC) #2

sadrul

8 years, 1 month ago (2012-11-09 23:44:21 UTC) #3

On 2012/11/09 23:39:05, abarth wrote:
> Yes, this looks great!  Thanks for iterating on the approach!  LGTM

Awesome! I have merges this change with the other CL
http://codereview.chromium.org/11368071/. Thanks for the very quick reviews.
Much appreciated.

Expand Messages | Collapse Messages