Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: src/codegen.cc

Issue 113763: Merge in changes from readability review. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | src/log.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 } 204 }
205 205
206 return code; 206 return code;
207 } 207 }
208 208
209 209
210 #ifdef ENABLE_LOGGING_AND_PROFILING 210 #ifdef ENABLE_LOGGING_AND_PROFILING
211 211
212 bool CodeGenerator::ShouldGenerateLog(Expression* type) { 212 bool CodeGenerator::ShouldGenerateLog(Expression* type) {
213 ASSERT(type != NULL); 213 ASSERT(type != NULL);
214 if (!Logger::is_enabled()) return false; 214 if (!Logger::IsEnabled()) return false;
215 Handle<String> name = Handle<String>::cast(type->AsLiteral()->handle()); 215 Handle<String> name = Handle<String>::cast(type->AsLiteral()->handle());
216 if (FLAG_log_regexp) { 216 if (FLAG_log_regexp) {
217 static Vector<const char> kRegexp = CStrVector("regexp"); 217 static Vector<const char> kRegexp = CStrVector("regexp");
218 if (name->IsEqualTo(kRegexp)) 218 if (name->IsEqualTo(kRegexp))
219 return true; 219 return true;
220 } 220 }
221 return false; 221 return false;
222 } 222 }
223 223
224 #endif 224 #endif
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
632 void ArgumentsAccessStub::Generate(MacroAssembler* masm) { 632 void ArgumentsAccessStub::Generate(MacroAssembler* masm) {
633 switch (type_) { 633 switch (type_) {
634 case READ_LENGTH: GenerateReadLength(masm); break; 634 case READ_LENGTH: GenerateReadLength(masm); break;
635 case READ_ELEMENT: GenerateReadElement(masm); break; 635 case READ_ELEMENT: GenerateReadElement(masm); break;
636 case NEW_OBJECT: GenerateNewObject(masm); break; 636 case NEW_OBJECT: GenerateNewObject(masm); break;
637 } 637 }
638 } 638 }
639 639
640 640
641 } } // namespace v8::internal 641 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | src/log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698