Merge in changes from readability review.

Merge in changes from readability review.

All changes from http://codereview.chromium.org/115024, except splitting namespace declarations in two lines (will be done separately for all source files).

Committed: http://code.google.com/p/v8/source/detail?r=2037

[Søren Thygesen Gjesse, 2009-05-25 06:38:31]

LGTM

Congratulations on you C++ readability!

http://codereview.chromium.org/113763/diff/1/5
File src/log.cc (right):

http://codereview.chromium.org/113763/diff/1/5#newcode308
Line 308: static bool is_enabled() {
How about changing this to IsEnabled() as well? This is no really an accessor.

http://codereview.chromium.org/113763/diff/1/7
File test/cctest/test-func-name-inference.cc (right):

http://codereview.chromium.org/113763/diff/1/7#newcode35
Line 35: using ::v8::internal::CStrVector;
I must admit that I would prefer to not use "using" and either use a namespace
alias or use full namespaces, but lets keep it with "using" for now and getting
rid of the  mix of "using" and namespace alias is good.

[Mikhail Naganov, 2009-05-25 08:38:51]

http://codereview.chromium.org/113763/diff/1/5
File src/log.cc (right):

http://codereview.chromium.org/113763/diff/1/5#newcode308
Line 308: static bool is_enabled() {
On 2009/05/25 06:38:31, Søren Gjesse wrote:
> How about changing this to IsEnabled() as well? This is no really an accessor.

Good idea. Done.

http://codereview.chromium.org/113763/diff/1/7
File test/cctest/test-func-name-inference.cc (right):

http://codereview.chromium.org/113763/diff/1/7#newcode35
Line 35: using ::v8::internal::CStrVector;
On 2009/05/25 06:38:31, Søren Gjesse wrote:
> I must admit that I would prefer to not use "using" and either use a namespace
> alias or use full namespaces, but lets keep it with "using" for now and
getting
> rid of the  mix of "using" and namespace alias is good.

Honestly, me too, because when using "using" it's good to have some auto-checker
that helps to get rid of no more used imports (like the tool that track imports
for Java).