Issue 113758: Remove the HistoryState property of WebRequest....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113758: Remove the HistoryState property of WebRequest.... (Closed)

Created:
11 years, 7 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove the HistoryState property of WebRequest. In the new WebKit API, it seems best if WebRequest is just a wrapper for WebCore::ResourceRequest since in most contexts that's what we need it to be. The solution here is to introduce a LoadHistoryState method on WebFrame that can be used to navigate to a session history item. BUG=10038 TEST=covered by existing back/forward navigation tests. R=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16747

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -78 lines)			Patch
M	chrome/renderer/render_view.cc	View	1	2 chunks	+31 lines, -21 lines	0 comments	Download
M	webkit/glue/webframe.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	1	4 chunks	+14 lines, -5 lines	0 comments	Download
M	webkit/glue/weburlrequest.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/glue/weburlrequest_impl.h	View	1	2 chunks	+0 lines, -7 lines	0 comments	Download
M	webkit/glue/weburlrequest_impl.cc	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1	1 chunk	+33 lines, -31 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 7 months ago (2009-05-22 15:50:49 UTC) #2

LGTM

http://codereview.chromium.org/113758/diff/1/9
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/113758/diff/1/9#newcode807
Line 807: if (!is_reload && !params.state.empty()) {
Can you add a comment to each arm of this if statement exaplining what that
state represents? Also, it wasn't immediately clear why state.empty mattered
here, can you mention that in the comment about this?

Expand Messages | Collapse Messages