chrome/browser/autocomplete/autocomplete_edit_view_mac.h - Issue 113751: Don't make |field_| first responder in SetSelectedRange() unless |model_| has_focus already.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_mac.h

Issue 113751: Don't make |field_| first responder in SetSelectedRange() unless |model_| has_focus already. (Closed)

Patch Set: Comment wordsmithing. Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/autocomplete_edit_view_mac.h

diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_mac.h b/chrome/browser/autocomplete/autocomplete_edit_view_mac.h

index aec861ce20ddc3feab6a24bc9c22a15c4904e962..8f7007043c00c2dca38d38426cb29c2e879c93d8 100644

--- a/chrome/browser/autocomplete/autocomplete_edit_view_mac.h

+++ b/chrome/browser/autocomplete/autocomplete_edit_view_mac.h

@@ -111,7 +111,8 @@ class AutocompleteEditViewMac : public AutocompleteEditView {

// situations.

bool IsFirstResponder() const;

- // Grab focus if needed and set the selection to |range|.

+ // If |model_| believes it has focus, grab focus if needed and set

+ // the selection to |range|. Otherwise does nothing.

void SetSelectedRange(const NSRange range);

// Update the field with |display_text| and highlight the host and

« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_edit_view_mac.mm » ('j') | no next file with comments »