New FFmpeg public API headers to match our source tarball in deps.

New FFmpeg public API headers to match our source tarball in deps.

[scherkus (not reviewing), 2009-05-21 23:57:46]

media_posix.cc: I alphabetized, added comments and a few missing "= NULL" to the
_ptr variables

also cleaned up the .def files to remove some functions we don't use

It's running on the try server so I'll let you know how that goes

[scherkus (not reviewing), 2009-05-22 00:42:13]

minor fixes (gyp, unit tests) to get things building on win/linux (try server
reports all good)

[awong, 2009-05-22 01:18:38]

lgtm.

small style issues.

http://codereview.chromium.org/113748/diff/13/14
File media/base/media_posix.cc (right):

http://codereview.chromium.org/113748/diff/13/14#newcode25
Line 25: // make modifying this file easier.
python man, python.

http://codereview.chromium.org/113748/diff/13/17
File media/filters/ffmpeg_demuxer_unittest.cc (right):

http://codereview.chromium.org/113748/diff/13/17#newcode148
Line 148: packet->destruct(packet);
the destruct will free it?  and we don't need to free "packet" itself right?

http://codereview.chromium.org/113748/diff/13/18
File media/filters/ffmpeg_video_decoder.cc (right):

http://codereview.chromium.org/113748/diff/13/18#newcode87
Line 87: packet.data = const_cast<uint8*>(buffer->GetData());
Is that safe?  const_casting? Add comment explaining why it's okay to change
this?

http://codereview.chromium.org/113748/diff/13/19
File third_party/ffmpeg/README.chromium (right):

http://codereview.chromium.org/113748/diff/13/19#newcode9
Line 9: 3) Follow the instructions to build and install
period. :)

http://codereview.chromium.org/113748/diff/13/19#newcode11
Line 11: /include/libavcodec
What's "/include"?

[scherkus (not reviewing), 2009-05-22 18:37:32]

http://codereview.chromium.org/113748/diff/13/17
File media/filters/ffmpeg_demuxer_unittest.cc (right):

http://codereview.chromium.org/113748/diff/13/17#newcode148
Line 148: packet->destruct(packet);
On 2009/05/22 01:18:38, awong wrote:
> the destruct will free it?  and we don't need to free "packet" itself right?

FFmpeg's "destructs" only take care of freeing whatever packet->data points to.

If you look at av_new_packet() you'll see we allocate and assign data to
packet->data and then assign &DestructPacket to packet->destruct.

http://codereview.chromium.org/113748/diff/13/18
File media/filters/ffmpeg_video_decoder.cc (right):

http://codereview.chromium.org/113748/diff/13/18#newcode87
Line 87: packet.data = const_cast<uint8*>(buffer->GetData());
On 2009/05/22 01:18:38, awong wrote:
> Is that safe?  const_casting? Add comment explaining why it's okay to change
> this?

FFmpeg changed their API and we lost our const-ness for in parameters
grrrrrrrrrrrrr

http://codereview.chromium.org/113748/diff/13/19
File third_party/ffmpeg/README.chromium (right):

http://codereview.chromium.org/113748/diff/13/19#newcode9
Line 9: 3) Follow the instructions to build and install
On 2009/05/22 01:18:38, awong wrote:
> period. :)

Done.

http://codereview.chromium.org/113748/diff/13/19#newcode11
Line 11: /include/libavcodec
On 2009/05/22 01:18:38, awong wrote:
> What's "/include"?

Done. (Sorta)

[awong, 2009-05-22 18:45:57]

lgtm