Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8282)

Unified Diff: chrome/test/memory_test/memory_test.cc

Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/interactive_ui/npapi_interactive_test.cc ('k') | chrome/test/page_cycler/page_cycler_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/memory_test/memory_test.cc
===================================================================
--- chrome/test/memory_test/memory_test.cc (revision 17078)
+++ chrome/test/memory_test/memory_test.cc (working copy)
@@ -213,8 +213,8 @@
size_t start_size = GetSystemCommitCharge();
// Cycle through the URLs.
- scoped_ptr<BrowserProxy> window(automation()->GetBrowserWindow(0));
- scoped_ptr<TabProxy> tab(window->GetActiveTab());
+ scoped_refptr<BrowserProxy> window(automation()->GetBrowserWindow(0));
+ scoped_refptr<TabProxy> tab(window->GetActiveTab());
int expected_tab_count = 1;
for (unsigned counter = 0; counter < arraysize(urls); ++counter) {
std::string url = urls[counter];
@@ -233,12 +233,12 @@
EXPECT_TRUE(window->AppendTab(GURL(url)));
expected_tab_count++;
WaitUntilTabCount(expected_tab_count);
- tab.reset(window->GetActiveTab());
+ tab = window->GetActiveTab();
continue;
}
int tab_index = counter % num_target_tabs; // A pseudo-random tab.
- tab.reset(window->GetTab(tab_index));
+ tab = window->GetTab(tab_index);
}
const int kMaxWaitTime = 5000;
« no previous file with comments | « chrome/test/interactive_ui/npapi_interactive_test.cc ('k') | chrome/test/page_cycler/page_cycler_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698