Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4786)

Unified Diff: chrome/test/automated_ui_tests/automated_ui_test_test.cc

Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automated_ui_tests/automated_ui_test_test.cc
===================================================================
--- chrome/test/automated_ui_tests/automated_ui_test_test.cc (revision 17078)
+++ chrome/test/automated_ui_tests/automated_ui_test_test.cc (working copy)
@@ -104,9 +104,8 @@
active_browser()->GetTabCount(&tab_count);
ASSERT_EQ(1, tab_count);
- BrowserProxy* previous_browser;
- ASSERT_TRUE(OpenAndActivateNewBrowserWindow(&previous_browser));
- scoped_ptr<BrowserProxy>browser_1(previous_browser);
+ scoped_refptr<BrowserProxy> browser_1;
+ ASSERT_TRUE(OpenAndActivateNewBrowserWindow(&browser_1));
automation()->GetBrowserWindowCount(&num_browser_windows);
ASSERT_EQ(2, num_browser_windows);
active_browser()->GetTabCount(&tab_count);
@@ -117,8 +116,8 @@
active_browser()->GetTabCount(&tab_count);
ASSERT_EQ(2, tab_count);
- ASSERT_TRUE(OpenAndActivateNewBrowserWindow(&previous_browser));
- scoped_ptr<BrowserProxy>browser_2(previous_browser);
+ scoped_refptr<BrowserProxy> browser_2;
+ ASSERT_TRUE(OpenAndActivateNewBrowserWindow(&browser_2));
automation()->GetBrowserWindowCount(&num_browser_windows);
ASSERT_EQ(3, num_browser_windows);
active_browser()->GetTabCount(&tab_count);
« no previous file with comments | « chrome/test/automated_ui_tests/automated_ui_test_base.cc ('k') | chrome/test/automated_ui_tests/automated_ui_tests.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698