Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: chrome/test/automated_ui_tests/automated_ui_test_base.h

Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automated_ui_tests/automated_ui_test_base.h
===================================================================
--- chrome/test/automated_ui_tests/automated_ui_test_base.h (revision 17078)
+++ chrome/test/automated_ui_tests/automated_ui_test_base.h (working copy)
@@ -62,7 +62,8 @@
// If optional parameter previous_browser is passed in, it is set to be the
// previous browser window when new window is successfully created, and the
// caller owns previous_browser.
- bool OpenAndActivateNewBrowserWindow(BrowserProxy** previous_browser);
+ bool OpenAndActivateNewBrowserWindow(
+ scoped_refptr<BrowserProxy>* previous_browser);
// Reload the active tab.
// Returns true if successful, false otherwise.
@@ -89,7 +90,7 @@
bool RunCommand(int browser_command);
void set_active_browser(BrowserProxy* browser) {
- active_browser_.reset(browser);
+ active_browser_ = browser;
}
BrowserProxy* active_browser() const { return active_browser_.get(); }
@@ -97,9 +98,9 @@
// create a corresponding TabProxy and transfer the ownership to caller.
// If success return the pointer to the newly created TabProxy and the
// caller owns the TabProxy. Return NULL otherwise.
- TabProxy* GetActiveTab();
+ scoped_refptr<TabProxy> GetActiveTab();
private:
- scoped_ptr<BrowserProxy> active_browser_;
+ scoped_refptr<BrowserProxy> active_browser_;
DISALLOW_COPY_AND_ASSIGN(AutomatedUITestBase);
};
« no previous file with comments | « chrome/test/accessibility/accessibility_tests.cc ('k') | chrome/test/automated_ui_tests/automated_ui_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698