Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1730)

Unified Diff: chrome/test/automation/window_proxy.h

Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/tab_proxy.cc ('k') | chrome/test/automation/window_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/window_proxy.h
===================================================================
--- chrome/test/automation/window_proxy.h (revision 17078)
+++ chrome/test/automation/window_proxy.h (working copy)
@@ -34,7 +34,6 @@
AutomationHandleTracker* tracker,
int handle)
: AutomationResourceProxy(tracker, sender, handle) {}
- virtual ~WindowProxy() {}
#if defined(OS_WIN)
// TODO(port): Use portable replacements for windowsisms.
@@ -89,12 +88,14 @@
// Returns the browser this window corresponds to, or NULL if this window
// is not a browser. The caller owns the returned BrowserProxy.
- BrowserProxy* GetBrowser();
+ scoped_refptr<BrowserProxy> GetBrowser();
// Same as GetWindow except return NULL if response isn't received
// before the specified timeout.
- BrowserProxy* GetBrowserWithTimeout(uint32 timeout_ms, bool* is_timeout);
-
+ scoped_refptr<BrowserProxy> GetBrowserWithTimeout(uint32 timeout_ms,
+ bool* is_timeout);
+ protected:
+ virtual ~WindowProxy() {}
private:
DISALLOW_COPY_AND_ASSIGN(WindowProxy);
};
« no previous file with comments | « chrome/test/automation/tab_proxy.cc ('k') | chrome/test/automation/window_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698