Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/test/reliability/page_load_test.cc

Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/plugin/plugin_test.cpp ('k') | chrome/test/selenium/selenium_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/reliability/page_load_test.cc
===================================================================
--- chrome/test/reliability/page_load_test.cc (revision 17078)
+++ chrome/test/reliability/page_load_test.cc (working copy)
@@ -168,7 +168,7 @@
// assertion when page loading fails. We log the result instead.
{
// TabProxy should be released before Browser is closed.
- scoped_ptr<TabProxy> tab_proxy(GetActiveTab());
+ scoped_refptr<TabProxy> tab_proxy(GetActiveTab());
if (tab_proxy.get()) {
result = tab_proxy->NavigateToURLWithTimeout(url, timeout_ms,
&is_timeout);
@@ -177,9 +177,9 @@
if (!is_timeout && result == AUTOMATION_MSG_NAVIGATION_SUCCESS) {
if (page_down) {
// Page down twice.
- scoped_ptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
+ scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
if (browser.get()) {
- scoped_ptr<WindowProxy> window(browser->GetWindow());
+ scoped_refptr<WindowProxy> window(browser->GetWindow());
if (window.get()) {
bool activation_timeout;
browser->BringToFrontWithTimeout(action_max_timeout_ms(),
@@ -372,7 +372,7 @@
LaunchBrowserAndServer();
{
// TabProxy should be released before Browser is closed.
- scoped_ptr<TabProxy> tab_proxy(GetActiveTab());
+ scoped_refptr<TabProxy> tab_proxy(GetActiveTab());
if (tab_proxy.get()) {
tab_proxy->NavigateToURL(GURL(test_url_1));
}
« no previous file with comments | « chrome/test/plugin/plugin_test.cpp ('k') | chrome/test/selenium/selenium_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698