Make automation proxy objects to ref_counted. That allows to process async no...

chrome/test/automated_ui_tests/automated_ui_test_base.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/scoped_ptr.h"
 #include "chrome/app/chrome_dll_resource.h"
 #include "chrome/test/automated_ui_tests/automated_ui_test_base.h"
 #include "chrome/test/automation/browser_proxy.h"
 #include "chrome/test/automation/tab_proxy.h"
 #include "chrome/test/automation/window_proxy.h"
 #include "chrome/test/ui/ui_test.h"
 
 AutomatedUITestBase::AutomatedUITestBase() {}
 
 AutomatedUITestBase::~AutomatedUITestBase() {}
@@ skipping 43 matching lines @@
     return false;
   // Avoid quitting the application by not closing the last window.
   if (browser_windows_count < 2)
     return false;
   bool application_closed;
   CloseBrowser(active_browser(), &application_closed);
   if (application_closed) {
     LogErrorMessage("Application closed unexpectedly.");
     return false;
   }
-  BrowserProxy* browser = automation()->FindNormalBrowserWindow();
-  if (browser == NULL) {
+  scoped_refptr<BrowserProxy> browser(automation()->FindNormalBrowserWindow());
+  if (!browser.get()) {
     LogErrorMessage("Can't find browser window.");
     return false;
   }
   set_active_browser(browser);
   return true;
 }
 
 bool AutomatedUITestBase::DuplicateTab() {
   return RunCommand(IDC_DUPLICATE_TAB);
 }
 
 bool AutomatedUITestBase::ForwardButton() {
   return RunCommand(IDC_FORWARD);
 }
 
 bool AutomatedUITestBase::GoOffTheRecord() {
   return RunCommand(IDC_NEW_INCOGNITO_WINDOW);
 }
 
 bool AutomatedUITestBase::OpenAndActivateNewBrowserWindow(
-    BrowserProxy** previous_browser) {
+    scoped_refptr<BrowserProxy>* previous_browser) {
   if (!automation()->OpenNewBrowserWindow(SW_SHOWNORMAL)) {
     LogWarningMessage("failed_to_open_new_browser_window");
     return false;
   }
   int num_browser_windows;
   automation()->GetBrowserWindowCount(&num_browser_windows);
   // Get the most recently opened browser window and activate the tab
   // in order to activate this browser window.
-  scoped_ptr<BrowserProxy> browser(
+  scoped_refptr<BrowserProxy> browser(
       automation()->GetBrowserWindow(num_browser_windows - 1));
   if (browser.get() == NULL) {
     LogErrorMessage("browser_window_not_found");
     return false;
   }
   bool is_timeout;
   if (!browser->ActivateTabWithTimeout(0, action_max_timeout_ms(),
                                        &is_timeout)) {
     LogWarningMessage("failed_to_activate_tab");
     return false;
   }
 
+  if (previous_browser) {
+    DCHECK(previous_browser->get() == NULL);
+    active_browser_.swap(*previous_browser);
+  }
+
   active_browser_.swap(browser);
-  if (previous_browser)
-    *previous_browser = browser.release();
   return true;
 }
 
 bool AutomatedUITestBase::Navigate(const GURL& url) {
-  scoped_ptr<TabProxy> tab(GetActiveTab());
+  scoped_refptr<TabProxy> tab(GetActiveTab());
   if (tab.get() == NULL) {
     LogErrorMessage("active_tab_not_found");
     return false;
   }
   bool did_timeout = false;
   tab->NavigateToURLWithTimeout(url,
                                 command_execution_timeout_ms(),
                                 &did_timeout);
 
   if (did_timeout) {
@@ skipping 38 matching lines @@
     return false;
   }
 
   if (!browser->RunCommand(browser_command)) {
     LogWarningMessage("failure_running_browser_command");
     return false;
   }
   return true;
 }
 
-TabProxy* AutomatedUITestBase::GetActiveTab() {
+scoped_refptr<TabProxy> AutomatedUITestBase::GetActiveTab() {
   BrowserProxy* browser = active_browser();
   if (browser == NULL) {
     LogErrorMessage("browser_window_not_found");
     return false;
   }
 
   bool did_timeout;
-  TabProxy* tab =
+  scoped_refptr<TabProxy> tab =
       browser->GetActiveTabWithTimeout(action_max_timeout_ms(), &did_timeout);
   if (did_timeout)
     return NULL;
   return tab;
 }