Return empty handle from GetEventContext for ScriptCollected events

For ScriptCollected events current context may be null. Message.GetEventContext will return an empty handle in such cases.

Committed: http://code.google.com/p/v8/source/detail?r=2024

[Søren Thygesen Gjesse, 2009-05-21 13:43:38]

LGTM

http://codereview.chromium.org/113698/diff/9/1007
File src/debug.cc (right):

http://codereview.chromium.org/113698/diff/9/1007#newcode2403
Line 2403: // Top::context() may have been NULL when the event occured.
Please add "script collected" before event in comment.

http://codereview.chromium.org/113698/diff/9/1006
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/113698/diff/9/1006#newcode4849
Line 4849: // Count the number of breaks.
breaks -> scripts collected

http://codereview.chromium.org/113698/diff/9/1006#newcode4884
Line 4884: Heap::CollectAllGarbageIfContextDisposed();
Maybe use Heap::CollectAllGarbage(), instad of
Heap::CollectAllGarbageIfContextDisposed() to avoid depending on the heuristics
of the latter.

http://codereview.chromium.org/113698/diff/9/1006#newcode4889
Line 4889: // Should SetMessageHandler2 cause execution of
Debugger::UnloadDebugger like
It should, but please remove this comment and open a bug instead.

[yurys, 2009-05-21 14:16:54]

http://codereview.chromium.org/113698/diff/9/1007
File src/debug.cc (right):

http://codereview.chromium.org/113698/diff/9/1007#newcode2403
Line 2403: // Top::context() may have been NULL when the event occured.
On 2009/05/21 13:43:38, Søren Gjesse wrote:
> Please add "script collected" before event in comment.

Done.

http://codereview.chromium.org/113698/diff/9/1006
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/113698/diff/9/1006#newcode4849
Line 4849: // Count the number of breaks.
On 2009/05/21 13:43:38, Søren Gjesse wrote:
> breaks -> scripts collected

Done.

http://codereview.chromium.org/113698/diff/9/1006#newcode4884
Line 4884: Heap::CollectAllGarbageIfContextDisposed();
On 2009/05/21 13:43:38, Søren Gjesse wrote:
> Maybe use Heap::CollectAllGarbage(), instad of
> Heap::CollectAllGarbageIfContextDisposed() to avoid depending on the
heuristics
> of the latter.

Done.

http://codereview.chromium.org/113698/diff/9/1006#newcode4889
Line 4889: // Should SetMessageHandler2 cause execution of
Debugger::UnloadDebugger like
On 2009/05/21 13:43:38, Søren Gjesse wrote:
> It should, but please remove this comment and open a bug instead.

Done.