Delayed adding BluetoothEventRouter as BluetoothAdapter observer until when the

chrome/browser/extensions/bluetooth_event_router_unittest.cc

Index: chrome/browser/extensions/bluetooth_event_router_unittest.cc
diff --git a/chrome/browser/extensions/bluetooth_event_router_unittest.cc b/chrome/browser/extensions/bluetooth_event_router_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0666545877e957875b7d94e539b49b4a48d64b94
--- /dev/null
+++ b/chrome/browser/extensions/bluetooth_event_router_unittest.cc
@@ -0,0 +1,60 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/bluetooth_event_router.h"
+#include "chrome/browser/extensions/event_names.h"
+#include "chrome/test/base/testing_profile.h"
+#include "device/bluetooth/test/mock_bluetooth_adapter.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+const char* kAdapterAddress = "Mock Adapter address for testing";
+const char* kName = "Mock Adapter name for testing";
+const char* kNonBluetoothEventName = "Non bluetooth event name";

[miket_OOO, 2012/11/06 02:04:09]

add vertical whitespace to balance the namespace {

[youngki, 2012/11/06 16:18:54]

Done.

+}  // namespace
+
+namespace extensions {
+
+class ExtensionBluetoothEventRouterTest : public testing::Test {
+ public:
+  ExtensionBluetoothEventRouterTest()
+      : mock_adapter_(new testing::StrictMock<device::MockBluetoothAdapter>(
+            kAdapterAddress, kName)),
+        router_(&profile_, mock_adapter_) {
+  }
+
+  virtual ~ExtensionBluetoothEventRouterTest() {
+    EXPECT_CALL(*mock_adapter_, RemoveObserver(testing::_));
+  }
+
+ protected:
+  TestingProfile profile_;
+  testing::StrictMock<device::MockBluetoothAdapter>* mock_adapter_;
+  ExtensionBluetoothEventRouter router_;
+};
+
+TEST_F(ExtensionBluetoothEventRouterTest, GetAdapter) {
+  EXPECT_EQ(mock_adapter_, router_.adapter());
+}
+
+TEST_F(ExtensionBluetoothEventRouterTest, GetMutableAdapter) {
+  EXPECT_CALL(*mock_adapter_, AddObserver(testing::_))
+      .WillOnce(testing::Return());
+  EXPECT_EQ(mock_adapter_, router_.GetMutableAdapter());

[miket_OOO, 2012/11/06 02:04:09]

More on earlier comment: it seems that if you run this line twice, you'll hit
http://code.google.com/searchframe#OAMlx_jo-ck/src/base/observer_list.h&exact....
If it doesn't make sense for someone to call it twice in the real world, then
never mind.

[youngki, 2012/11/06 16:18:54]

Added a test case to make sure that AddObserver is called only once even if the
multiple bluetooth event listeners are added.

+}
+
+TEST_F(ExtensionBluetoothEventRouterTest, BluetoothEventListenerAdded) {
+  EXPECT_CALL(*mock_adapter_, AddObserver(testing::_))
+      .WillOnce(testing::Return());
+  router_.OnEventListenerAdded(
+      extensions::event_names::kBluetoothOnAvailabilityChanged);
+}
+
+TEST_F(ExtensionBluetoothEventRouterTest, NonBluetoothEventListenerAdded) {
+  router_.OnEventListenerAdded(kNonBluetoothEventName);
+}
+
+}  // namespace extensions