chrome/browser/ui/webui/options/core_options_handler.cc - Issue 11368098: Draft change to use base::Closure instead of PrefObserver in PrefChangeRegistrar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.cc

Issue 11368098: Draft change to use base::Closure instead of PrefObserver in PrefChangeRegistrar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to review comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/core_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/core_options_handler.cc b/chrome/browser/ui/webui/options/core_options_handler.cc

index 8e14ea1df858665de4a9063ac193524f3063a194..a49a69becab6208dead0f985eef4e973e85fbfbc 100644

--- a/chrome/browser/ui/webui/options/core_options_handler.cc

+++ b/chrome/browser/ui/webui/options/core_options_handler.cc

@@ -206,9 +206,9 @@ void CoreOptionsHandler::ObservePref(const std::string& pref_name) {

void CoreOptionsHandler::StopObservingPref(const std::string& pref_name) {

if (g_browser_process->local_state()->FindPreference(pref_name.c_str()))

- local_state_registrar_.Remove(pref_name.c_str(), this);

+ local_state_registrar_.Remove(pref_name.c_str());

else

- registrar_.Remove(pref_name.c_str(), this);

+ registrar_.Remove(pref_name.c_str());

}

void CoreOptionsHandler::SetPref(const std::string& pref_name,

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | no next file » | no next file with comments »