Draft change to use base::Closure instead of PrefObserver in PrefChangeRegistrar.

chrome/browser/prefs/pref_notifier_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_notifier_impl.h"
 
+#include "base/bind.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "chrome/browser/prefs/pref_service.h"
 
 PrefNotifierImpl::PrefNotifierImpl()
     : pref_service_(NULL) {
 }
 
 PrefNotifierImpl::PrefNotifierImpl(PrefService* service)
     : pref_service_(service) {
 }
 
 PrefNotifierImpl::~PrefNotifierImpl() {
   DCHECK(CalledOnValidThread());
 
   // Verify that there are no pref observers when we shut down.
   for (PrefObserverMap::iterator it = pref_observers_.begin();
        it != pref_observers_.end(); ++it) {
-    PrefObserverList::Iterator obs_iterator(*(it->second));
-    if (obs_iterator.GetNext()) {
+    if (!it->second->empty()) {
       LOG(WARNING) << "pref observer found at shutdown " << it->first;
     }
   }
 
   // Same for initialization observers.
   if (!init_observers_.empty())
     LOG(WARNING) << "Init observer found at shutdown.";
 
   STLDeleteContainerPairSecondPointers(pref_observers_.begin(),
                                        pref_observers_.end());
   pref_observers_.clear();
   init_observers_.clear();
 }
 
 void PrefNotifierImpl::AddPrefObserver(const char* path,
-                                       PrefObserver* obs) {
+                                       const base::Closure& obs) {
   // Get the pref observer list associated with the path.
   PrefObserverList* observer_list = NULL;
   const PrefObserverMap::iterator observer_iterator =
       pref_observers_.find(path);
   if (observer_iterator == pref_observers_.end()) {
     observer_list = new PrefObserverList;
     pref_observers_[path] = observer_list;
   } else {
     observer_list = observer_iterator->second;
   }
 
-  // Add the pref observer. ObserverList will DCHECK if it already is
-  // in the list.
-  observer_list->AddObserver(obs);
+  // Add the pref observer.
+  // TODO(joi): DO NOT COMMIT must DCHECK if already in list
+  observer_list->push_back(obs);
 }
 
+class SameObserverPredicate {
+ public:
+  SameObserverPredicate(const base::Closure& observer) : obs_(observer) {}
+
+  bool operator ()(const base::Closure& other) {
+    return obs_.Equals(other);
+  }
+
+ private:
+  const base::Closure& obs_;
+};
+
 void PrefNotifierImpl::RemovePrefObserver(const char* path,
-                                          PrefObserver* obs) {
+                                          const base::Closure& obs) {
   DCHECK(CalledOnValidThread());
 
   const PrefObserverMap::iterator observer_iterator =
       pref_observers_.find(path);
   if (observer_iterator == pref_observers_.end()) {
     return;
   }
 
   PrefObserverList* observer_list = observer_iterator->second;
-  observer_list->RemoveObserver(obs);
+  // TODO(joi): DO NOT COMMIT, DCHECK if not found.
+  observer_list->erase(
+      std::find_if(observer_list->begin(), observer_list->end(),
+                   SameObserverPredicate(obs)));
 }
 
 void PrefNotifierImpl::AddInitObserver(base::Callback<void(bool)> obs) {
   init_observers_.push_back(obs);
 }
 
 void PrefNotifierImpl::OnPreferenceChanged(const std::string& path) {
   FireObservers(path);
 }
 
@@ skipping 18 matching lines @@
 
   // Only send notifications for registered preferences.
   if (!pref_service_->FindPreference(path.c_str()))
     return;
 
   const PrefObserverMap::iterator observer_iterator =
       pref_observers_.find(path);
   if (observer_iterator == pref_observers_.end())
     return;
 
-  FOR_EACH_OBSERVER(PrefObserver,
-                    *(observer_iterator->second),
-                    OnPreferenceChanged(pref_service_, path));
+  for (PrefObserverList::iterator it = observer_iterator->second->begin();
+       it != observer_iterator->second->end();
+       ++it) {
+    it->Run();
+  }
 }
 
 void PrefNotifierImpl::SetPrefService(PrefService* pref_service) {
   DCHECK(pref_service_ == NULL);
   pref_service_ = pref_service;
 }