content/renderer/browser_plugin/browser_plugin_browsertest.cc - Issue 11368071: browser-plugin: Remove event handling code, and use CustomEvents in webkit instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin_browsertest.cc

Issue 11368071: browser-plugin: Remove event handling code, and use CustomEvents in webkit instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/browser_plugin/browser_plugin.cc ('K') | « content/renderer/browser_plugin/browser_plugin_bindings.cc ('k') | content/test/data/browser_plugin_embedder.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin_browsertest.cc

diff --git a/content/renderer/browser_plugin/browser_plugin_browsertest.cc b/content/renderer/browser_plugin/browser_plugin_browsertest.cc

index 723aa8e383fcbbfd09bf775447df8d67485eabea..98ebeb5cea24d02f43982f8e10139ae5c69bc004 100644

--- a/content/renderer/browser_plugin/browser_plugin_browsertest.cc

+++ b/content/renderer/browser_plugin/browser_plugin_browsertest.cc

@@ -274,7 +274,7 @@ TEST_F(BrowserPluginTest, GuestCrash) {

const char* kAddEventListener =

"var msg;"

"function exitListener(e) {"

- " msg = e.type;"

+ " msg = e.reason;"

"}"

"document.getElementById('browserplugin')."

" addEventListener('exit', exitListener);";

@@ -616,7 +616,7 @@ TEST_F(BrowserPluginTest, RemoveBrowserPluginOnExit) {

const char* kAddEventListener =

"function exitListener(e) {"

- " if (e.type == 'killed') {"

+ " if (e.reason == 'killed') {"

" var bp = document.getElementById('browserplugin');"

" bp.parentNode.removeChild(bp);"

" }"