chrome/test/data/extensions/platform_apps/web_view_src_attribute/main.js - Issue 11368071: browser-plugin: Remove event handling code, and use CustomEvents in webkit instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/web_view_src_attribute/main.js

Issue 11368071: browser-plugin: Remove event handling code, and use CustomEvents in webkit instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/platform_apps/web_view/main.js ('K') | « chrome/test/data/extensions/platform_apps/web_view/main.js ('k') | content/renderer/browser_plugin/browser_plugin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/web_view_src_attribute/main.js

diff --git a/chrome/test/data/extensions/platform_apps/web_view_src_attribute/main.js b/chrome/test/data/extensions/platform_apps/web_view_src_attribute/main.js

index 66984297e13e819fc756c792de5f9bb84e428299..df47079f49b49278d7c3127a61ddf67fd8c99dcf 100644

--- a/chrome/test/data/extensions/platform_apps/web_view_src_attribute/main.js

+++ b/chrome/test/data/extensions/platform_apps/web_view_src_attribute/main.js

@@ -10,7 +10,7 @@ var checkSrc = function(element, expectedValue) {

onload = function() {

chrome.test.runTests([

- function webview() {

+ function webView() {

var expectedSrcOne = 'data:text/html,<body>One</body>';

var expectedSrcTwo = 'data:text/html,<body>Two</body>';

var expectedSrcThree = 'data:text/html,<body>Three</body>';

@@ -59,7 +59,6 @@ onload = function() {

}, 0);

};

// Wait for navigation to complete before checking src attribute.

webview.addEventListener('loadcommit', function(e) {

switch (step) {

@@ -74,7 +73,8 @@ onload = function() {

break;

default:

// Unchecked.

- chrome.test.fail('Unexpected step: ' + step);

+ chrome.test.fail('Unexpected step: ' + step + ' with url: ' +

+ e.url);

}

});

}