browser-plugin: Remove event handling code, and use CustomEvents in webkit instead.

chrome/renderer/resources/extensions/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Shim that simulates a <webview> tag via Mutation Observers.
 //
 // The actual tag is implemented via the browser plugin. The internals of this
 // are hidden via Shadow DOM.
 
 var WEB_VIEW_ATTRIBUTES = ['src'];
 
 var WEB_VIEW_READONLY_ATTRIBUTES = ['contentWindow'];
 
 // All exposed api methods for <webview>, these are forwarded to the browser
 // plugin.
 var WEB_VIEW_API_METHODS = [
-    'addEventListener',
-    'back',
-    'canGoBack',
-    'canGoForward',
-    'forward',
-    'getProcessId',
-    'go',
-    'reload',
-    'removeEventListener',
-    'stop',
-    'terminate'
-    ];
+  'back',
+  'canGoBack',
+  'canGoForward',
+  'forward',
+  'getProcessId',
+  'go',
+  'reload',
+  'stop',
+  'terminate'
+];
+
+var WEB_VIEW_EVENTS = {
+  'exit' : [ 'processId', 'reason' ],

[arv (Not doing code reviews), 2012/11/12 22:58:07]

no ws after [ nor before ]

[sadrul, 2012/11/12 23:03:21]

Done.

+  'loadabort' : [ 'url', 'isTopLevel', 'reason' ],
+  'loadcommit' : [ 'url', 'isTopLevel' ],
+  'loadredirect' : [ 'oldurl', 'newurl', 'isTopLevel' ],
+  'loadstart' : [ 'url', 'isTopLevel' ],
+  'loadstop' : [],
+  'sizechanged': [ 'oldHeight', 'oldWidth', 'newHeight', 'newWidth' ],
+};
 
 window.addEventListener('DOMContentLoaded', function() {
   // Handle <webview> tags already in the document.
   var webViewNodes = document.body.querySelectorAll('webview');
   for (var i = 0, webViewNode; webViewNode = webViewNodes[i]; i++) {
     new WebView(webViewNode);
   }
 
   // Handle <webview> tags added later.
   var documentObserver = new WebKitMutationObserver(function(mutations) {
@@ skipping 65 matching lines @@
   WEB_VIEW_READONLY_ATTRIBUTES.forEach(function(attributeName) {
     Object.defineProperty(this.node_, attributeName, {
       get: function() {
         // Read these attributes from the plugin <object>.
         return objectNode[attributeName];
       },
       // No setter.
       enumerable: true
     })
   }, this);
+
+  for (eventname in WEB_VIEW_EVENTS) {

[arv (Not doing code reviews), 2012/11/12 22:58:07]

eventName

[arv (Not doing code reviews), 2012/11/12 22:58:07]

missing var

You should really use strict mode for these things. Less risk for security
issues as well.

[sadrul, 2012/11/12 23:03:21]

Done.

[sadrul, 2012/11/12 23:03:21]

Done.
It doesn't look like any of the scripts in this location use the strict mode. I
do not know if that is deliberate or not.

+    this.setupEvent_(eventname, WEB_VIEW_EVENTS[eventname]);
+  }
 };
 
 /**
  * @private
  */
 WebView.prototype.handleMutation_ = function(mutation) {
   switch (mutation.attributeName) {
     case 'src':
       // We need to set .src directly on the shadow element so that
       // BrowserPluginBindings catches this as src attribute mutation. The
       // bindings would catch 'SetAttribute' method call with src as argument
       // otherwise.
       this.objectNode_.src = this.node_.getAttribute('src');
       break;
     default:
       this.copyAttribute_(mutation.attributeName);
       break;
   }
 };
 
 /**
  * @private
  */
 WebView.prototype.copyAttribute_ = function(attributeName) {
   this.objectNode_.setAttribute(
       attributeName, this.node_.getAttribute(attributeName));
 };
+
+/**
+ * @private
+ */
+WebView.prototype.setupEvent_ = function(eventname, attribs) {
+  var node = this.node_;
+  this.objectNode_.addEventListener('-internal-' + eventname, function(e) {
+    var evt = new Event(eventname);
+    var detail = e.detail ? JSON.parse(e.detail) : {};
+    attribs.forEach(function(attribname) {

[arv (Not doing code reviews), 2012/11/12 22:58:07]

attribName

[sadrul, 2012/11/12 23:03:21]

Done.

+      evt[attribname] = detail[attribname];
+    });
+    node.dispatchEvent(evt);
+  });
+}