Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 113671: Fixes the problem of the status bubble obscuring the download shelf.... (Closed)

Created:
11 years, 7 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This fixes the problem of the status bubble obscuring the download shelf. BUG= http://crbug.com/6590 TEST=Cause the download shelf to appear by initiating a download. Hover over a link in the extreme lower left corner of the browser window. The status bubble should avoid your mouse by moving to the right, instead of moving down and obscuring the download shelf. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17025

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : Fixes problem of status bubble obscuring download shelf. #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : Fixed browser.cc, which had become outdated. #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M chrome/browser/browser.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/status_bubble_mac.h View 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/status_bubble_mac.mm View 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/status_bubble_gtk.h View 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/status_bubble.h View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_delegate.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/status_bubble_views.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 1 2 3 4 5 6 7 8 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Miranda Callahan
This is basically a tweak of Yusuke's code to move the status bubble when the ...
11 years, 7 months ago (2009-05-20 22:41:54 UTC) #1
Yusuke (unused)
http://codereview.chromium.org/113671/diff/32/1034 File chrome/browser/views/status_bubble_views.cc (right): http://codereview.chromium.org/113671/diff/32/1034#newcode612 Line 612: offset > kBubbleCornerRadius / 2 - kShadowThickness)) { ...
11 years, 7 months ago (2009-05-22 05:48:14 UTC) #2
Miranda Callahan
http://codereview.chromium.org/113671/diff/32/1034 File chrome/browser/views/status_bubble_views.cc (right): http://codereview.chromium.org/113671/diff/32/1034#newcode612 Line 612: offset > kBubbleCornerRadius / 2 - kShadowThickness)) { ...
11 years, 7 months ago (2009-05-26 17:14:06 UTC) #3
Yusuke (unused)
LGTM LGTM, but please note that I'm not a chromium committer. Glen may have a ...
11 years, 7 months ago (2009-05-27 01:03:29 UTC) #4
Miranda Callahan
Thank you, Yusuke! I'll commit if Glen gives the ok... On 2009/05/27 01:03:29, Yusuke wrote: ...
11 years, 7 months ago (2009-05-27 16:21:26 UTC) #5
Glen Murphy
11 years, 7 months ago (2009-05-27 17:54:51 UTC) #6
LGTM.

Erik Kay should also take a quick peek as he is adding other bottom-shelves, and
maybe we want to abstract it into something like, but less ridiculous-sounding
than "Content Area Bottom Changed".

But don't let that stop you committing now.

Powered by Google App Engine
This is Rietveld 408576698