This is the first pass at making GetIPConfigs asynchronous.

chromeos/dbus/shill_service_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/shill_service_client.h"
 
 #include "base/bind.h"
 #include "base/chromeos/chromeos_version.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
@@ skipping 18 matching lines @@
       "Failed to call org.chromium.shill.Service.GetProperties for: " +
       service_path.value() + ": " + error_name + ": " + error_message;
 
   // Suppress ERROR log if error name is
   // "org.freedesktop.DBus.Error.UnknownMethod". crbug.com/130660
   if (error_name == DBUS_ERROR_UNKNOWN_METHOD)
     VLOG(1) << log_string;
   else
     LOG(ERROR) << log_string;
 
-  base::DictionaryValue empty_dictionary;
-  callback.Run(DBUS_METHOD_CALL_FAILURE, empty_dictionary);
+  scoped_ptr<base::DictionaryValue> empty_dictionary(new base::DictionaryValue);
+  callback.Run(DBUS_METHOD_CALL_FAILURE, empty_dictionary.Pass());
 }
 
 // The ShillServiceClient implementation.
 class ShillServiceClientImpl : public ShillServiceClient {
  public:
   explicit ShillServiceClientImpl(dbus::Bus* bus)
       : bus_(bus),
         helpers_deleter_(&helpers_) {
   }
 
@@ skipping 298 matching lines @@
     SetServiceProperty("stub_cellular1",
                        flimflam::kNetworkTechnologyProperty,
                        technology_value);
   }
 
   void PassStubDictionaryValue(const dbus::ObjectPath& service_path,
                                const DictionaryValueCallback& callback) {
     base::DictionaryValue* dict = NULL;
     if (!stub_services_.GetDictionaryWithoutPathExpansion(
             service_path.value(), &dict)) {
-      base::DictionaryValue empty_dictionary;
-      callback.Run(DBUS_METHOD_CALL_FAILURE, empty_dictionary);
+      scoped_ptr<base::DictionaryValue> empty(new base::DictionaryValue);
+      callback.Run(DBUS_METHOD_CALL_FAILURE, empty.Pass());
       return;
     }
-    callback.Run(DBUS_METHOD_CALL_SUCCESS, *dict);
+    scoped_ptr<base::DictionaryValue> result_copy(dict->DeepCopy());
+    callback.Run(DBUS_METHOD_CALL_SUCCESS, result_copy.Pass());
   }
 
   void NotifyObserversPropertyChanged(const dbus::ObjectPath& service_path,
                                       const std::string& property) {
     base::DictionaryValue* dict = NULL;
     std::string path = service_path.value();
     if (!stub_services_.GetDictionaryWithoutPathExpansion(path, &dict)) {
       LOG(ERROR) << "Notify for unknown service: " << path;
       return;
     }
@@ skipping 39 matching lines @@
 ShillServiceClient* ShillServiceClient::Create(
     DBusClientImplementationType type,
     dbus::Bus* bus) {
   if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
     return new ShillServiceClientImpl(bus);
   DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
   return new ShillServiceClientStubImpl();
 }
 
 }  // namespace chromeos