This is the first pass at making GetIPConfigs asynchronous.

chromeos/dbus/shill_client_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/shill_client_helper.h"
 
 #include "base/bind.h"
 #include "base/values.h"
 #include "dbus/message.h"
 #include "dbus/object_proxy.h"
@@ skipping 259 matching lines @@
     error_callback.Run(kInvalidResponseErrorName, kInvalidResponseErrorMessage);
     return;
   }
   callback.Run(result);
 }
 
 void ShillClientHelper::OnDictionaryValueMethod(
     const DictionaryValueCallback& callback,
     dbus::Response* response) {
   if (!response) {
-    base::DictionaryValue result;
-    callback.Run(DBUS_METHOD_CALL_FAILURE, result);
+    scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue);
+    callback.Run(DBUS_METHOD_CALL_FAILURE, result.Pass());
     return;
   }
   dbus::MessageReader reader(response);
-  scoped_ptr<base::Value> value(dbus::PopDataAsValue(&reader));
+  base::Value* value = dbus::PopDataAsValue(&reader);
   base::DictionaryValue* result = NULL;
-  if (!value.get() || !value->GetAsDictionary(&result)) {
-    base::DictionaryValue result;
-    callback.Run(DBUS_METHOD_CALL_FAILURE, result);
+  if (!value || !value->GetAsDictionary(&result)) {
+    delete value;
+    scoped_ptr<base::DictionaryValue> empty_ptr(new base::DictionaryValue);
+    callback.Run(DBUS_METHOD_CALL_FAILURE, empty_ptr.Pass());
     return;
   }
-  callback.Run(DBUS_METHOD_CALL_SUCCESS, *result);
+
+  scoped_ptr<base::DictionaryValue> result_ptr(result);
+  callback.Run(DBUS_METHOD_CALL_SUCCESS, result_ptr.Pass());
 }
 
 void ShillClientHelper::OnVoidMethodWithErrorCallback(
     const base::Closure& callback,
     dbus::Response* response) {
   callback.Run();
 }
 
 void ShillClientHelper::OnDictionaryValueMethodWithErrorCallback(
     const DictionaryValueCallbackWithoutStatus& callback,
     const ErrorCallback& error_callback,
     dbus::Response* response) {
   dbus::MessageReader reader(response);
-  scoped_ptr<base::Value> value(dbus::PopDataAsValue(&reader));
+  base::Value* value(dbus::PopDataAsValue(&reader));
   base::DictionaryValue* result = NULL;
-  if (!value.get() || !value->GetAsDictionary(&result)) {
+  if (!value || !value->GetAsDictionary(&result)) {
+    delete value;
     error_callback.Run(kInvalidResponseErrorName, kInvalidResponseErrorMessage);
     return;
   }
-  callback.Run(*result);
+  scoped_ptr<base::DictionaryValue> result_ptr(result);
+  callback.Run(result_ptr.Pass());
 }
 
 void ShillClientHelper::OnError(const ErrorCallback& error_callback,
                                 dbus::ErrorResponse* response) {
   std::string error_name;
   std::string error_message;
   if (response) {
     // Error message may contain the error message as string.
     dbus::MessageReader reader(response);
     error_name = response->GetErrorName();
     reader.PopString(&error_message);
   }
   error_callback.Run(error_name, error_message);
 }
 
 }  // namespace chromeos