Merged String subclasses into String.

runtime/vm/dart_api_impl.h

Index: runtime/vm/dart_api_impl.h
diff --git a/runtime/vm/dart_api_impl.h b/runtime/vm/dart_api_impl.h
index 28c24dc080a214f5c1a767a28b281cc950cfe77d..1018bc5ed145be89d9f5fa1ff48806f77060c611 100644
--- a/runtime/vm/dart_api_impl.h
+++ b/runtime/vm/dart_api_impl.h
@@ -81,7 +81,7 @@ class Api : AllStatic {
 #define DECLARE_UNWRAP(Type)                                                   \
   static const Type& Unwrap##Type##Handle(Isolate* isolate,                    \
                                           Dart_Handle object);
-  CLASS_LIST_NO_OBJECT(DECLARE_UNWRAP)
+  CLASS_LIST_NO_OBJECT_WITH_STRING(DECLARE_UNWRAP)

[siva, 2012/11/05 19:23:38]

CLASS_LIST_NO_OBJECT_WITH_STRING is kind of hard to read
(does it mean no object_with_string is included in the list)?

Maybe we could spell it out explicitly here:
#define DECLARE_UNWRAP(type)
.....
CLASS_LIST_NO_OBJECT_OR_STRING(DECLARE_UNWRAP)
DECLARE_UNWRAP(String)
#undef DECLARE_UNWRAP

or have a macro
#define CLASS_LIST_FOR_HANDLES(V)                          \
  CLASS_LIST_NO_OBJECT_OR_STRING                           \
  V(String)
defined in object.h

[Tom Ball, 2012/11/05 21:22:41]

Implemented your macro suggestion.

 #undef DECLARE_UNWRAP
 
   // Validates and converts the passed in handle as a local handle.