Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Unified Diff: content/browser/web_contents/web_contents_view_android.cc

Issue 11366118: Add support for interstitial pages on android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_android.cc
diff --git a/content/browser/web_contents/web_contents_view_android.cc b/content/browser/web_contents/web_contents_view_android.cc
index b4d67fa7bc0cb1e03ab524fdbceb9d8e3d4591d6..5a5a1c77c6758a58096dc2b5de5a817c4e78faf0 100644
--- a/content/browser/web_contents/web_contents_view_android.cc
+++ b/content/browser/web_contents/web_contents_view_android.cc
@@ -44,7 +44,11 @@ void WebContentsViewAndroid::SetContentViewCore(
if (rwhv)
rwhv->SetContentViewCore(content_view_core_);
if (web_contents_->ShowingInterstitialPage()) {
- NOTIMPLEMENTED() << "not upstreamed yet";
+ rwhv = static_cast<RenderWidgetHostViewAndroid*>(
+ web_contents_->GetInterstitialPage()->
+ GetRenderViewHost()->GetView());
+ if (rwhv)
no sievers 2012/11/06 22:42:56 Can this ever be null? Should it match the logic i
Ted C 2012/11/07 01:34:31 Based on the number of checks in content_view_core
+ rwhv->SetContentViewCore(content_view_core_);
}
}

Powered by Google App Engine
This is Rietveld 408576698