gclient.py - Issue 113656: Fix the print_error parsing, which caused spurious errors on gcl usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient.py

Issue 113656: Fix the print_error parsing, which caused spurious errors on gcl usage. (Closed)

Patch Set: Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gclient.py

diff --git a/gclient.py b/gclient.py

index 8eeee6efd20bec4f79bc31f95fbd3ec8dc7c7fed..8646f319d3406631a8d7a13647b7f48c0ac95783 100755

--- a/gclient.py

+++ b/gclient.py

@@ -509,7 +509,7 @@ def CaptureSVN(args, in_directory=None, print_error=True):

# when it's called with a list because it only tries to execute the

# first string ("svn").

stderr = None

- if print_error:

+ if not print_error:

stderr = subprocess.PIPE

return subprocess.Popen(c,

cwd=in_directory,

« no previous file with comments | « no previous file | no next file » | no next file with comments »