Added a script to remove headers from the target....

Added a script to remove headers from the target.
Added a default in common.gypi to remove headers from all mac applications that are bundles.
Added a var to control the inclusion of keystone to chrome.gyp defaulted on branding and then honor it for the shipping work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16510

[Mark Mentovai, 2009-05-20 18:43:13]

otay.

http://codereview.chromium.org/113652/diff/1/4
File build/mac/remove_target_headers (right):

http://codereview.chromium.org/113652/diff/1/4#newcode11
Line 11: find "${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}" -iname 'Headers' -type d
-prune -delete
80

http://codereview.chromium.org/113652/diff/1/4#newcode12
Line 12: 
This blank line isn't really needed.

http://codereview.chromium.org/113652/diff/1/3
File build/mac/tweak_app_infoplist (right):

http://codereview.chromium.org/113652/diff/1/3#newcode11
Line 11: USE_KS=0
I would spell out KEYSTONE (like BREAKPAD).

http://codereview.chromium.org/113652/diff/1/3#newcode118
Line 118: if [ "${USE_BREAKPAD}" == "1" ] ; then
Strictly speaking, test/[ uses = for string equality, not ==.

http://codereview.chromium.org/113652/diff/1/3#newcode142
Line 142: if [ \( "${USE_KS}" == "1" \) -a \( "${CONFIGURATION}" == "Release" \)
] ; then
-a is ass.  That's what it stands for, in fact.  You're better off with:

if [ "${USE_KS}" = "1" ] && [ "${CONFIGURATION}" = "Release" ] ; then

-a doesn't short-circuit and is pretty much obsolete.

http://codereview.chromium.org/113652/diff/1/3#newcode146
Line 146: defaults write "${TMP_INFO_PLIST_DEFAULTS}" KSVersion -string
"${FULL_VERSION}"
80