Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chromeos/dbus/cros_disks_client.cc

Issue 11365142: Small refactoring in DiskMountManager (event reporting; format method). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clangt Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/dbus/cros_disks_client.h" 5 #include "chromeos/dbus/cros_disks_client.h"
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 device_path, 222 device_path,
223 callback, 223 callback,
224 error_callback)); 224 error_callback));
225 } 225 }
226 226
227 // CrosDisksClient override. 227 // CrosDisksClient override.
228 virtual void SetUpConnections( 228 virtual void SetUpConnections(
229 const MountEventHandler& mount_event_handler, 229 const MountEventHandler& mount_event_handler,
230 const MountCompletedHandler& mount_completed_handler) OVERRIDE { 230 const MountCompletedHandler& mount_completed_handler) OVERRIDE {
231 static const SignalEventTuple kSignalEventTuples[] = { 231 static const SignalEventTuple kSignalEventTuples[] = {
232 { cros_disks::kDeviceAdded, DEVICE_ADDED }, 232 { cros_disks::kDeviceAdded, CROS_DISKS_DEVICE_ADDED },
233 { cros_disks::kDeviceScanned, DEVICE_SCANNED }, 233 { cros_disks::kDeviceScanned, CROS_DISKS_DEVICE_SCANNED },
234 { cros_disks::kDeviceRemoved, DEVICE_REMOVED }, 234 { cros_disks::kDeviceRemoved, CROS_DISKS_DEVICE_REMOVED },
235 { cros_disks::kDiskAdded, DISK_ADDED }, 235 { cros_disks::kDiskAdded, CROS_DISKS_DISK_ADDED },
236 { cros_disks::kDiskChanged, DISK_CHANGED }, 236 { cros_disks::kDiskChanged, CROS_DISKS_DISK_CHANGED },
237 { cros_disks::kDiskRemoved, DISK_REMOVED }, 237 { cros_disks::kDiskRemoved, CROS_DISKS_DISK_REMOVED },
238 { cros_disks::kFormattingFinished, FORMATTING_FINISHED }, 238 { cros_disks::kFormattingFinished, CROS_DISKS_FORMATTING_FINISHED },
239 }; 239 };
240 const size_t kNumSignalEventTuples = arraysize(kSignalEventTuples); 240 const size_t kNumSignalEventTuples = arraysize(kSignalEventTuples);
241 241
242 for (size_t i = 0; i < kNumSignalEventTuples; ++i) { 242 for (size_t i = 0; i < kNumSignalEventTuples; ++i) {
243 proxy_->ConnectToSignal( 243 proxy_->ConnectToSignal(
244 cros_disks::kCrosDisksInterface, 244 cros_disks::kCrosDisksInterface,
245 kSignalEventTuples[i].signal_name, 245 kSignalEventTuples[i].signal_name,
246 base::Bind(&CrosDisksClientImpl::OnMountEvent, 246 base::Bind(&CrosDisksClientImpl::OnMountEvent,
247 weak_ptr_factory_.GetWeakPtr(), 247 weak_ptr_factory_.GetWeakPtr(),
248 kSignalEventTuples[i].event_type, 248 kSignalEventTuples[i].event_type,
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 // static 604 // static
605 CrosDisksClient* CrosDisksClient::Create(DBusClientImplementationType type, 605 CrosDisksClient* CrosDisksClient::Create(DBusClientImplementationType type,
606 dbus::Bus* bus) { 606 dbus::Bus* bus) {
607 if (type == REAL_DBUS_CLIENT_IMPLEMENTATION) 607 if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
608 return new CrosDisksClientImpl(bus); 608 return new CrosDisksClientImpl(bus);
609 DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type); 609 DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
610 return new CrosDisksClientStubImpl(); 610 return new CrosDisksClientStubImpl();
611 } 611 }
612 612
613 } // namespace chromeos 613 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698