Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: chromeos/network/network_sms_handler.cc

Issue 11365022: Add TestInterface methods for adding shill stub devices and services (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix clang warnings Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/network_sms_handler.h" 5 #include "chromeos/network/network_sms_handler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 device_path)); 393 device_path));
394 } 394 }
395 } 395 }
396 } 396 }
397 397
398 void NetworkSmsHandler::DevicePropertiesCallback( 398 void NetworkSmsHandler::DevicePropertiesCallback(
399 const std::string& device_path, 399 const std::string& device_path,
400 DBusMethodCallStatus call_status, 400 DBusMethodCallStatus call_status,
401 const base::DictionaryValue& properties) { 401 const base::DictionaryValue& properties) {
402 if (call_status != DBUS_METHOD_CALL_SUCCESS) { 402 if (call_status != DBUS_METHOD_CALL_SUCCESS) {
403 LOG(ERROR) << "NetworkSmsHandler: ERROR: " << call_status; 403 LOG(ERROR) << "NetworkSmsHandler: ERROR: " << call_status
404 << " For: " << device_path;
404 return; 405 return;
405 } 406 }
406 407
407 std::string device_type; 408 std::string device_type;
408 if (!properties.GetStringWithoutPathExpansion( 409 if (!properties.GetStringWithoutPathExpansion(
409 flimflam::kTypeProperty, &device_type)) { 410 flimflam::kTypeProperty, &device_type)) {
410 LOG(ERROR) << "NetworkSmsHandler: No type for: " << device_path; 411 LOG(ERROR) << "NetworkSmsHandler: No type for: " << device_path;
411 return; 412 return;
412 } 413 }
413 if (device_type != flimflam::kTypeCellular) 414 if (device_type != flimflam::kTypeCellular)
(...skipping 21 matching lines...) Expand all
435 this, dbus_connection, object_path)); 436 this, dbus_connection, object_path));
436 } else { 437 } else {
437 device_handlers_.push_back( 438 device_handlers_.push_back(
438 new ModemManagerNetworkSmsDeviceHandler( 439 new ModemManagerNetworkSmsDeviceHandler(
439 this, dbus_connection, object_path)); 440 this, dbus_connection, object_path));
440 } 441 }
441 } 442 }
442 443
443 444
444 } // namespace chromeos 445 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698