chrome/browser/printing/print_preview_tab_controller_unittest.cc - Issue 11364202: Get full WebPluginInfo for the PDF plug-in before enabling it for print preview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_tab_controller_unittest.cc

Issue 11364202: Get full WebPluginInfo for the PDF plug-in before enabling it for print preview. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix? Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_tab_controller.cc ('k') | chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_tab_controller_unittest.cc

diff --git a/chrome/browser/printing/print_preview_tab_controller_unittest.cc b/chrome/browser/printing/print_preview_tab_controller_unittest.cc

index e16e46bb9e6808c641a8a956b30b4746451e2447..7113bd53e5a1a4e37bb3ae9acc254628732c51f5 100644

--- a/chrome/browser/printing/print_preview_tab_controller_unittest.cc

+++ b/chrome/browser/printing/print_preview_tab_controller_unittest.cc

@@ -16,7 +16,9 @@

#include "content/public/browser/navigation_details.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_types.h"

+#include "content/public/browser/plugin_service.h"

#include "content/public/common/url_constants.h"

+#include "webkit/plugins/npapi/mock_plugin_list.h"

// Test crashes on Aura due to initiator tab's native view having no parent.

// http://crbug.com/104284

@@ -39,8 +41,16 @@ class PrintPreviewTabControllerUnitTest : public BrowserWithTestWindowTest {

virtual void SetUp() OVERRIDE {

BrowserWithTestWindowTest::SetUp();

+ // The PluginService will be destroyed at the end of the test (due to the

+ // ShadowingAtExitManager in our base class).

+ content::PluginService::GetInstance()->SetPluginListForTesting(

+ &plugin_list_);

profile()->GetPrefs()->SetBoolean(prefs::kPrintPreviewDisabled, false);

}

+ private:

+ webkit::npapi::MockPluginList plugin_list_;

};

// Create/Get a preview tab for initiator tab.