cc: Clean up PageScaleAnimation for readability.

cc: Clean up PageScaleAnimation for readability.

No-op change.

BUG=152505
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167615

[aelias_OOO_until_Jul13, 2012-11-10 00:18:50]

Hi Dana, this applies your code review comments from yesterday along with a few
other cleanups.

[danakj, 2012-11-10 00:26:18]

Thanks for the CL! I'll read thru it again once you rebase this, as it's going
to conflict with some of the things I did while landing all the ui/gfx changes.

Would you mind fixing the Vector2d named "targetPosition" inconsistency in
LayerTreeHostImpl while you're doing this as well?

[aelias_OOO_until_Jul13, 2012-11-10 00:45:29]

In LayerTreeHostImpl, the "targetPosition" is overloaded to sometimes be an
scroll offset and sometimes a tap position, depending on the boolean isAnchor. 
I plan to fix this later by splitting it into two values (which it turns out
sometimes we can both use anyway).

[danakj, 2012-11-10 00:48:52]

On 2012/11/10 00:45:29, aelias wrote:
> In LayerTreeHostImpl, the "targetPosition" is overloaded to sometimes be an
> scroll offset and sometimes a tap position, depending on the boolean isAnchor.

> I plan to fix this later by splitting it into two values (which it turns out
> sometimes we can both use anyway).

Ok, tho since it can be both now, I'd just rather the variable name matched its
type rather than contradicted it. ie Vector2ds should be named as offsets.

[danakj, 2012-11-12 23:08:30]

This should be able to rebase now, everything relevant in ui/gfx has landed
minus BottomRight() in cc/geometry.h which I haven't attempted to upstream yet.

[aelias_OOO_until_Jul13, 2012-11-14 00:24:47]

Rebased, PTAL.

[danakj, 2012-11-14 00:47:23]

lgtm and thank you very much for it!

http://codereview.chromium.org/11364189/diff/9001/cc/page_scale_animation.cc
File cc/page_scale_animation.cc (right):

http://codereview.chromium.org/11364189/diff/9001/cc/page_scale_animation.cc#...
cc/page_scale_animation.cc:114: gfx::Vector2dF normalized =
ScaleVector2d(m_startScrollOffset - m_targetScrollOffset, widthScale,
heightScale);
nit: gfx::ScaleVector2d

[aelias_OOO_until_Jul13, 2012-11-14 02:26:51]

http://codereview.chromium.org/11364189/diff/9001/cc/page_scale_animation.cc
File cc/page_scale_animation.cc (right):

http://codereview.chromium.org/11364189/diff/9001/cc/page_scale_animation.cc#...
cc/page_scale_animation.cc:114: gfx::Vector2dF normalized =
ScaleVector2d(m_startScrollOffset - m_targetScrollOffset, widthScale,
heightScale);
On 2012/11/14 00:47:23, danakj wrote:
> nit: gfx::ScaleVector2d

Done.

[commit-bot: I haz the power, 2012-11-14 02:30:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aelias@chromium.org/11364189/2003

[commit-bot: I haz the power, 2012-11-14 06:51:45]

Change committed as 167615