Issue 11364097: Allow Directory.create to create all missing path components.

Issue 11364097: Allow Directory.create to create all missing path components. (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow Directory.create to create all missing path components. Unified Directory.create/list/delete to take a named 'recursive' argument. Fixed bug in Path implementation on Windows. R=sgjesse@google.com BUG=dartbug.com/6024 Committed: https://code.google.com/p/dart/source/detail?r=14572

Patch Set 1 #

Patch Set 2 : Reupload #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -106 lines)			Patch
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/directory.dart	View	2 chunks	+38 lines, -32 lines	0 comments	Download
M	sdk/lib/io/directory_impl.dart	View	4 chunks	+42 lines, -23 lines	0 comments	Download
M	sdk/lib/io/path_impl.dart	View	1 chunk	+1 line, -1 line	2 comments	Download
M	tests/standalone/io/dart_std_io_pipe_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/directory_error_test.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/standalone/io/directory_fuzz_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/directory_test.dart	View	14 chunks	+43 lines, -15 lines	0 comments	Download
M	tests/standalone/io/file_error_test.dart	View	10 chunks	+10 lines, -10 lines	0 comments	Download
M	tests/standalone/io/file_fuzz_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/file_output_stream_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/file_system_links_test.dart	View	7 chunks	+9 lines, -9 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/io.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm http://codereview.chromium.org/11364097/diff/1003/sdk/lib/io/path_impl.dart File sdk/lib/io/path_impl.dart (right): http://codereview.chromium.org/11364097/diff/1003/sdk/lib/io/path_impl.dart#newcode193 sdk/lib/io/path_impl.dart:193: nativePath.startsWith('/') && Now that you are at it ...

8 years, 1 month ago (2012-11-06 10:45:26 UTC) #2

Mads Ager (google)

8 years, 1 month ago (2012-11-06 15:00:35 UTC) #3

http://codereview.chromium.org/11364097/diff/1003/sdk/lib/io/path_impl.dart
File sdk/lib/io/path_impl.dart (right):

http://codereview.chromium.org/11364097/diff/1003/sdk/lib/io/path_impl.dart#n...
sdk/lib/io/path_impl.dart:193: nativePath.startsWith('/') &&
On 2012/11/06 10:45:26, Søren Gjesse wrote:
> Now that you are at it maybe check that nativePath[1] is [A-Za-z].

Not sure we have to. If you use this and it doesn't exist you will get an error
from the system anyway.

Expand Messages | Collapse Messages