Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: chrome/browser/task_manager_browsertest.cc

Issue 113636: Create OpenClose browser test for TaskManager with necessary refactoring.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager.cc ('k') | chrome/browser/task_manager_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager_browsertest.cc
===================================================================
--- chrome/browser/task_manager_browsertest.cc (revision 16479)
+++ chrome/browser/task_manager_browsertest.cc (working copy)
@@ -11,9 +11,11 @@
};
// Regression test for http://crbug.com/11180
-IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, ShutdownWhileOpen) {
+IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, OpenClose) {
TaskManager::Open();
+ TaskManager::Close();
}
-// TODO(phajdan.jr): Write another test which explicitly closes TaskManager.
-// This requires a small refactoring.
+IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, ShutdownWhileOpen) {
+ TaskManager::Open();
+}
« no previous file with comments | « chrome/browser/task_manager.cc ('k') | chrome/browser/task_manager_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698