chrome/browser/download/save_page_browsertest.cc - Issue 11363222: Persist download interrupt reason, both target and current paths, and url_chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 11363222: Persist download interrupt reason, both target and current paths, and url_chain. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merged to r180302 Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_history_unittest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/save_page_browsertest.cc

diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc

index 77bc6ae9c6c3f707d8861ff1ad67f77daa198476..272ac271602f8d5fd67a0cc1aec4090964eeb083 100644

--- a/chrome/browser/download/save_page_browsertest.cc

+++ b/chrome/browser/download/save_page_browsertest.cc

@@ -150,13 +150,18 @@ bool DownloadStoredProperly(

// This function may be called multiple times for a given test. Returning

// false doesn't necessarily mean that the test has failed or will fail, it

// might just mean that the test hasn't passed yet.

- if (info.path != expected_path) {

- VLOG(20) << __FUNCTION__ << " " << info.path.value()

+ if (info.target_path != expected_path) {

+ VLOG(20) << __FUNCTION__ << " " << info.target_path.value()

<< " != " << expected_path.value();

return false;

}

- if (info.url != expected_url) {

- VLOG(20) << __FUNCTION__ << " " << info.url.spec()

+ if (info.url_chain.size() != 1u) {

+ VLOG(20) << __FUNCTION__ << " " << info.url_chain.size()

+ << " != 1";

+ return false;

+ }

+ if (info.url_chain[0] != expected_url) {

+ VLOG(20) << __FUNCTION__ << " " << info.url_chain[0].spec()

<< " != " << expected_url.spec();

return false;

}