chrome/browser/chromeos/cros/network_library.h - Issue 11363203: Get rid of use of CreateStringValue in chromeos/ directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/cros/network_library.h

Issue 11363203: Get rid of use of CreateStringValue in chromeos/ directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/cros/network_library.h

diff --git a/chrome/browser/chromeos/cros/network_library.h b/chrome/browser/chromeos/cros/network_library.h

index 5834154f73720d26cc3f80d448f8539b860a444b..fbce220f8dbaf0941326dc8b3d4e914de22e1560 100644

--- a/chrome/browser/chromeos/cros/network_library.h

+++ b/chrome/browser/chromeos/cros/network_library.h

@@ -492,7 +492,7 @@ class Network {

std::string* dest);

virtual void SetBooleanProperty(const char* prop, bool b, bool* dest);

virtual void SetIntegerProperty(const char* prop, int i, int* dest);

- virtual void SetValueProperty(const char* prop, base::Value* val);

+ virtual void SetValueProperty(const char* prop, const base::Value& val);

virtual void ClearProperty(const char* prop);

// This will clear the property if string is empty. Otherwise, it will set it.