Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/build_nexe.py

Issue 11363175: Honor werror variable for untrusted builds. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/standalone_flags.gypi » ('j') | build/untrusted.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/build_nexe.py
diff --git a/build/build_nexe.py b/build/build_nexe.py
index f467204594312b46d17553f5c40628246cde5571..0e8c4e19013da14505070d044d62a335c6ab904e 100644
--- a/build/build_nexe.py
+++ b/build/build_nexe.py
@@ -228,12 +228,6 @@ class Builder(object):
'NACL_OSX=0',
'NACL_LINUX=0'])
options += ['-D' + define for define in define_list]
- # TODO(mseaborn): Enable -Werror for ARM/PNaCl when warnings in
- # Chromium's PPAPI proxy have been fixed, and move -Werror to
- # untrusted.gypi.
- # See http://code.google.com/p/nativeclient/issues/detail?id=3108
- if self.mainarch == 'x86':
- options.append('-Werror')
self.compile_options = options + ['-I' + name for name in self.inc_paths]
def BuildLinkOptions(self, options):
« no previous file with comments | « no previous file | build/standalone_flags.gypi » ('j') | build/untrusted.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698