Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/standalone_flags.gypi

Issue 11363175: Honor werror variable for untrusted builds. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/build_nexe.py ('k') | build/untrusted.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone_flags.gypi
diff --git a/build/standalone_flags.gypi b/build/standalone_flags.gypi
index a83e540d975be3f5cbdccfcdbb2a8b5a2fb28fac..dd0f304e6a9a41827bda9351e8672ef46a29f9c9 100644
--- a/build/standalone_flags.gypi
+++ b/build/standalone_flags.gypi
@@ -10,12 +10,6 @@
# these flags for Chrome source that is built as NaCl untrusted
# code.
'nacl_default_compile_flags': [
- # TODO(mseaborn): Move -Werror to untrusted.gypi so that it
- # applies to Chrome source built as untrusted code. We have
- # -Werror as a NaCl-side only flag at the moment because some
- # Chrome code produces warnings when built with PNaCl/ARM.
- # See http://code.google.com/p/nativeclient/issues/detail?id=3108
- '-Werror',
'-Wundef',
],
},
« no previous file with comments | « build/build_nexe.py ('k') | build/untrusted.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698