Add DBusStatistics and DBusLogSource to log and show dbus stats

dbus/dbus_statistics_unittest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "dbus/dbus_statistics.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace dbus {
+
+class DbusStatisticsTest : public testing::Test {
+ public:
+  DbusStatisticsTest() {
+  }
+
+  virtual void SetUp() {
+    DbusStatistics::Initialize();
+  }
+
+  virtual void TearDown() {
+    DbusStatistics::Shutdown();
+  }
+};
+
+TEST_F(DbusStatisticsTest, TestDbusStats) {
+  int sent = 0, received = 0;
+
+  // Add a sent call
+  DbusStatistics::AddSentCall("service1", "interface1", "method1");
+  ASSERT_TRUE(DbusStatistics::GetCallsForTesting(
+      "service1", "interface1", "method1", &sent, &received));
+  ASSERT_EQ(1, sent);
+  ASSERT_EQ(0, received);
+
+  // Add a received call
+  DbusStatistics::AddReceivedCall("service1", "interface1", "method1");
+  ASSERT_TRUE(DbusStatistics::GetCallsForTesting(
+      "service1", "interface1", "method1", &sent, &received));
+  ASSERT_EQ(1, sent);
+  ASSERT_EQ(1, received);
+
+  // Add some more stats
+  DbusStatistics::AddSentCall("service1", "interface1", "method2");
+  DbusStatistics::AddSentCall("service1", "interface1", "method2");
+  DbusStatistics::AddReceivedCall("service1", "interface1", "method2");
+
+  DbusStatistics::AddSentCall("service1", "interface1", "method3");
+  DbusStatistics::AddSentCall("service1", "interface1", "method3");
+  DbusStatistics::AddSentCall("service1", "interface1", "method3");
+
+  DbusStatistics::AddSentCall("service1", "interface2", "method1");
+
+  DbusStatistics::AddSentCall("service1", "interface2", "method2");
+
+  DbusStatistics::AddSentCall("service2", "interface1", "method1");
+
+  // Make sure all entries can be found in the set and their counts were
+  // incramented correctly.
+  ASSERT_TRUE(DbusStatistics::GetCallsForTesting(
+      "service1", "interface1", "method1", &sent, &received));
+  ASSERT_EQ(1, sent);
+  ASSERT_EQ(1, received);
+  ASSERT_TRUE(DbusStatistics::GetCallsForTesting(
+      "service1", "interface1", "method2", &sent, &received));
+  ASSERT_EQ(2, sent);
+  ASSERT_EQ(1, received);
+  ASSERT_TRUE(DbusStatistics::GetCallsForTesting(
+      "service1", "interface1", "method3", &sent, &received));
+  ASSERT_EQ(3, sent);
+  ASSERT_EQ(0, received);
+  ASSERT_TRUE(DbusStatistics::GetCallsForTesting(
+      "service1", "interface2", "method1", &sent, &received));
+  ASSERT_EQ(1, sent);
+  ASSERT_EQ(0, received);
+  ASSERT_TRUE(DbusStatistics::GetCallsForTesting(
+      "service1", "interface2", "method2", &sent, &received));
+  ASSERT_EQ(1, sent);
+  ASSERT_EQ(0, received);
+  ASSERT_TRUE(DbusStatistics::GetCallsForTesting(
+      "service2", "interface1", "method1", &sent, &received));
+  ASSERT_EQ(1, sent);
+  ASSERT_EQ(0, received);
+
+  ASSERT_FALSE(DbusStatistics::GetCallsForTesting(
+      "service1", "interface3", "method2", &sent, &received));
+}

[satorux1, 2012/11/12 00:40:43]

Add a test for GetAsString()? Having a test for the function would be useful, as
we can see how the output from the function looks like.

[stevenjb, 2012/11/12 19:46:40]

I think that this would be more likely to cause breakage if we change (or
localize) the formatting then catch anything helpful. I would rather describe
the output format in the header (done).

[gauravsh, 2012/11/12 21:41:58]

Surely, if one was changing the GetAsString method, you would expect them to
rebase the unit test too? It is more likely that the comment gets stale as
changes are made to GetAsString. It's not a trivial implementation either -
without a test, there is no way to be sure that it works as advertised.

+
+}  // namespace dbus