Add DBusStatistics and DBusLogSource to log and show dbus stats

chrome/browser/chromeos/system_logs/dbus_log_source.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/system_logs/dbus_log_source.h"
+
+#include "base/message_loop.h"

[hashimoto, 2012/11/12 04:33:16]

nit: No need to include this.

[stevenjb, 2012/11/12 19:46:40]

Done.

+#include "chrome/browser/chromeos/system_logs/system_logs_fetcher.h"
+#include "content/public/browser/browser_thread.h"
+#include "dbus/dbus_statistics.h"
+
+namespace chromeos {
+
+namespace {
+const char kDbusLogEntryShort[] = "dbus_summary";
+const char kDbusLogEntryLong[] = "dbus_details";
+}

[hashimoto, 2012/11/12 04:33:16]

nit: Add commenct "// namespace"

[stevenjb, 2012/11/12 19:46:40]

We usually don't bother when it's within a few lines with no whitespace.

+
+void DbusLogSource::Fetch(const SysLogsSourceCallback& callback) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  DCHECK(!callback.is_null());
+
+  scoped_ptr<SystemLogsResponse> response(new SystemLogsResponse);

[hashimoto, 2012/11/12 04:33:16]

Why do you store this object in scoped_ptr?
Doesn't "SystemLogResponse response;" work?

[stevenjb, 2012/11/12 19:46:40]

Yes actually, it looks like it can. The code that calls this is a bit confusing
(one callback type requires a scoped_ptr, but this one does not.
Done.

+  const bool show_per_minute = true;
+  (*response)[kDbusLogEntryShort] =
+      dbus::DbusStatistics::GetAsString(
+          dbus::DbusStatistics::SHOW_INTERFACE, show_per_minute);
+  (*response)[kDbusLogEntryLong] =
+      dbus::DbusStatistics::GetAsString(
+          dbus::DbusStatistics::SHOW_METHOD, !show_per_minute);
+  callback.Run(response.get());
+}
+
+}  // namespace chromeos