Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: build/android/findbugs_filter/findbugs_known_bugs.txt

Issue 11363150: Support Java resources within content and chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove obsolete findbugs warnings Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 H B ES: Comparison of String parameter using == or != in org.chromium.android_we bview.test.AwSettingsTest$AwSettingsUserAgentStringTestHelper.doEnsureSettingHas Value(String) At AwSettingsTest.java 1 H B ES: Comparison of String parameter using == or != in org.chromium.android_we bview.test.AwSettingsTest$AwSettingsUserAgentStringTestHelper.doEnsureSettingHas Value(String) At AwSettingsTest.java
2 H B Nm: The class name org.chromium.content.browser.test.util.TouchUtils shadows the simple name of the superclass android.test.TouchUtils At TouchUtils.java 2 H B Nm: The class name org.chromium.content.browser.test.util.TouchUtils shadows the simple name of the superclass android.test.TouchUtils At TouchUtils.java
3 H C EC: Using pointer equality to compare a JavaBridgeCoercionTest$CustomType wi th a JavaBridgeCoercionTest$CustomType2 in org.chromium.content.browser.JavaBrid geCoercionTest.testPassJavaObject() At JavaBridgeCoercionTest.java 3 H C EC: Using pointer equality to compare a JavaBridgeCoercionTest$CustomType wi th a JavaBridgeCoercionTest$CustomType2 in org.chromium.content.browser.JavaBrid geCoercionTest.testPassJavaObject() At JavaBridgeCoercionTest.java
4 H D RCN: Redundant nullcheck of org.chromium.content.browser.SandboxedProcessCon nection.mConnectionParams, which is known to be non-null in org.chromium.content .browser.SandboxedProcessConnection.doConnectionSetup() Redundant null check at SandboxedProcessConnection.java 4 H D RCN: Redundant nullcheck of org.chromium.content.browser.SandboxedProcessCon nection.mConnectionParams, which is known to be non-null in org.chromium.content .browser.SandboxedProcessConnection.doConnectionSetup() Redundant null check at SandboxedProcessConnection.java
5 H D ST: Write to static field org.chromium.content.app.SandboxedProcessService.s Context from instance method org.chromium.content.app.SandboxedProcessService.on Create() At SandboxedProcessService.java 5 H D ST: Write to static field org.chromium.content.app.SandboxedProcessService.s Context from instance method org.chromium.content.app.SandboxedProcessService.on Create() At SandboxedProcessService.java
6 H D ST: Write to static field org.chromium.net.test.util.TestWebServer.sInstance from instance method org.chromium.net.test.util.TestWebServer.shutdown() At Te stWebServer.java 6 H D ST: Write to static field org.chromium.net.test.util.TestWebServer.sInstance from instance method org.chromium.net.test.util.TestWebServer.shutdown() At Te stWebServer.java
7 H V MS: org.chromium.android_webview.test.AndroidWebViewTestBase.WAIT_TIMEOUT_SE CONDS isn't final but should be At AndroidWebViewTestBase.java 7 H V MS: org.chromium.android_webview.test.AndroidWebViewTestBase.WAIT_TIMEOUT_SE CONDS isn't final but should be At AndroidWebViewTestBase.java
8 H V MS: org.chromium.android_webview.test.LoadDataWithBaseUrlTest.WAIT_TIMEOUT_S ECONDS isn't final but should be At LoadDataWithBaseUrlTest.java 8 H V MS: org.chromium.android_webview.test.LoadDataWithBaseUrlTest.WAIT_TIMEOUT_S ECONDS isn't final but should be At LoadDataWithBaseUrlTest.java
9 H V MS: org.chromium.content.app.AppResource.ARRAY_OFFICIAL_COMMAND_LINE isn't f inal but should be In AppResource.java 9 H V MS: org.chromium.content.app.AppResource.ARRAY_OFFICIAL_COMMAND_LINE isn't f inal but should be In AppResource.java
10 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_COLORSTRIP_CORNER _RADII isn't final but should be In AppResource.java 10 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_COLORSTRIP_CORNER _RADII isn't final but should be In AppResource.java
(...skipping 28 matching lines...) Expand all
39 H V MS: org.chromium.content.app.AppResource.STRING_DATE_TIME_PICKER_DIALOG_TITL E isn't final but should be In AppResource.java 39 H V MS: org.chromium.content.app.AppResource.STRING_DATE_TIME_PICKER_DIALOG_TITL E isn't final but should be In AppResource.java
40 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_DONT_RELOAD_ THIS_PAGE isn't final but should be In AppResource.java 40 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_DONT_RELOAD_ THIS_PAGE isn't final but should be In AppResource.java
41 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_LEAVE_THIS_P AGE isn't final but should be In AppResource.java 41 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_LEAVE_THIS_P AGE isn't final but should be In AppResource.java
42 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_RELOAD_THIS_ PAGE isn't final but should be In AppResource.java 42 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_RELOAD_THIS_ PAGE isn't final but should be In AppResource.java
43 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_STAY_ON_THIS _PAGE isn't final but should be In AppResource.java 43 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_STAY_ON_THIS _PAGE isn't final but should be In AppResource.java
44 H V MS: org.chromium.content.app.AppResource.STRING_MONTH_PICKER_DIALOG_TITLE is n't final but should be In AppResource.java 44 H V MS: org.chromium.content.app.AppResource.STRING_MONTH_PICKER_DIALOG_TITLE is n't final but should be In AppResource.java
45 H V MS: org.chromium.content.browser.ContentViewTestBase.WAIT_TIMEOUT_SECONDS is n't final but should be At ContentViewTestBase.java 45 H V MS: org.chromium.content.browser.ContentViewTestBase.WAIT_TIMEOUT_SECONDS is n't final but should be At ContentViewTestBase.java
46 H V MS: org.chromium.content.browser.test.util.CallbackHelper.WAIT_TIMEOUT_SECON DS isn't final but should be At CallbackHelper.java 46 H V MS: org.chromium.content.browser.test.util.CallbackHelper.WAIT_TIMEOUT_SECON DS isn't final but should be At CallbackHelper.java
47 H V MS: org.chromium.content.browser.test.util.HistoryUtils.WAIT_TIMEOUT_SECONDS isn't final but should be At HistoryUtils.java 47 H V MS: org.chromium.content.browser.test.util.HistoryUtils.WAIT_TIMEOUT_SECONDS isn't final but should be At HistoryUtils.java
48 M B FS: Format string should use %n rather than \n in org.chromium.android_webvi ew.test.AwSettingsTest.testUserAgentStringDefault() At AwSettingsTest.java 48 M B FS: Format string should use %n rather than \n in org.chromium.android_webvi ew.test.AwSettingsTest.testUserAgentStringDefault() At AwSettingsTest.java
49 M B Nm: The class name org.chromium.android_webview.test.R$attr doesn't start wi th an upper case letter At R.java
50 M B Nm: The class name org.chromium.android_webview.test.R$drawable doesn't star t with an upper case letter At R.java
51 M B Nm: The class name org.chromium.android_webview.test.R$raw doesn't start wit h an upper case letter At R.java
52 M B Nm: The class name org.chromium.android_webview.test.R$string doesn't start with an upper case letter At R.java
53 M B Nm: The class name org.chromium.chrome.browser.component.navigation_intercep tion.InterceptNavigationDelegate shadows the simple name of implemented interfac e org.chromium.content.components.navigation_interception.InterceptNavigationDel egate In InterceptNavigationDelegate.java 49 M B Nm: The class name org.chromium.chrome.browser.component.navigation_intercep tion.InterceptNavigationDelegate shadows the simple name of implemented interfac e org.chromium.content.components.navigation_interception.InterceptNavigationDel egate In InterceptNavigationDelegate.java
54 M B Nm: The class name org.chromium.chrome.testshell.Manifest$permission doesn't start with an upper case letter At Manifest.java
55 M B Nm: The class name org.chromium.chrome.testshell.R$attr doesn't start with a n upper case letter At R.java
56 M B Nm: The class name org.chromium.chrome.testshell.R$dimen doesn't start with an upper case letter At R.java
57 M B Nm: The class name org.chromium.chrome.testshell.R$drawable doesn't start wi th an upper case letter At R.java
58 M B Nm: The class name org.chromium.chrome.testshell.R$id doesn't start with an upper case letter At R.java
59 M B Nm: The class name org.chromium.chrome.testshell.R$layout doesn't start with an upper case letter At R.java
60 M B Nm: The class name org.chromium.chrome.testshell.R$string doesn't start with an upper case letter At R.java
61 M B Nm: The class name org.chromium.chrome.testshell.tests.R$attr doesn't start with an upper case letter At R.java
62 M B Nm: The class name org.chromium.chrome.testshell.tests.R$dimen doesn't start with an upper case letter At R.java
63 M B Nm: The class name org.chromium.chrome.testshell.tests.R$drawable doesn't st art with an upper case letter At R.java
64 M B Nm: The class name org.chromium.chrome.testshell.tests.R$id doesn't start wi th an upper case letter At R.java
65 M B Nm: The class name org.chromium.chrome.testshell.tests.R$layout doesn't star t with an upper case letter At R.java
66 M B Nm: The class name org.chromium.chrome.testshell.tests.R$string doesn't star t with an upper case letter At R.java
67 M B Nm: The class name org.chromium.content_shell.Manifest$permission doesn't st art with an upper case letter At Manifest.java
68 M B Nm: The class name org.chromium.content_shell.R$attr doesn't start with an u pper case letter At R.java
69 M B Nm: The class name org.chromium.content_shell.R$dimen doesn't start with an upper case letter At R.java
70 M B Nm: The class name org.chromium.content_shell.R$drawable doesn't start with an upper case letter At R.java
71 M B Nm: The class name org.chromium.content_shell.R$id doesn't start with an upp er case letter At R.java
72 M B Nm: The class name org.chromium.content_shell.R$layout doesn't start with an upper case letter At R.java
73 M B Nm: The class name org.chromium.content_shell.R$string doesn't start with an upper case letter At R.java
74 M B Nm: The class name org.chromium.content_shell.tests.R$attr doesn't start wit h an upper case letter At R.java
75 M B Nm: The class name org.chromium.content_shell.tests.R$dimen doesn't start wi th an upper case letter At R.java
76 M B Nm: The class name org.chromium.content_shell.tests.R$drawable doesn't start with an upper case letter At R.java
77 M B Nm: The class name org.chromium.content_shell.tests.R$id doesn't start with an upper case letter At R.java
78 M B Nm: The class name org.chromium.content_shell.tests.R$layout doesn't start w ith an upper case letter At R.java
79 M B Nm: The class name org.chromium.content_shell.tests.R$string doesn't start w ith an upper case letter At R.java
80 M B Nm: The class name org.chromium.native_test.R$attr doesn't start with an upp er case letter At R.java
81 M B Nm: The class name org.chromium.native_test.R$string doesn't start with an u pper case letter At R.java
82 M B Nm: The method name org.chromium.base.test.util.ScalableTimeout.ScaleTimeout (long) doesn't start with a lower case letter At ScalableTimeout.java 50 M B Nm: The method name org.chromium.base.test.util.ScalableTimeout.ScaleTimeout (long) doesn't start with a lower case letter At ScalableTimeout.java
83 M B Nm: The method name org.chromium.content.browser.ContentViewCore.UpdateVSync (long, long) doesn't start with a lower case letter At ContentViewCore.java 51 M B Nm: The method name org.chromium.content.browser.ContentViewCore.UpdateVSync (long, long) doesn't start with a lower case letter At ContentViewCore.java
84 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu m.android_webview.test.ArchiveTest.doArchiveTest(AwContents, String, boolean, St ring) At ArchiveTest.java 52 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu m.android_webview.test.ArchiveTest.doArchiveTest(AwContents, String, boolean, St ring) At ArchiveTest.java
85 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu m.android_webview.test.ArchiveTest.testAutoBadPath() At ArchiveTest.java 53 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu m.android_webview.test.ArchiveTest.testAutoBadPath() At ArchiveTest.java
86 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu m.android_webview.test.ArchiveTest.testExplicitBadPath() At ArchiveTest.java 54 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu m.android_webview.test.ArchiveTest.testExplicitBadPath() At ArchiveTest.java
87 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu m.android_webview.test.ArchiveTest.testExplicitGoodPath() At ArchiveTest.java 55 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu m.android_webview.test.ArchiveTest.testExplicitGoodPath() At ArchiveTest.java
88 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu m.base.test.util.TestFileUtil.deleteFile(String) At TestFileUtil.java 56 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu m.base.test.util.TestFileUtil.deleteFile(String) At TestFileUtil.java
89 M C CSM: Shouldn't use synchronized method, please narrow down the synchronizati on scope. At HttpAuthDatabase.java 57 M C CSM: Shouldn't use synchronized method, please narrow down the synchronizati on scope. At HttpAuthDatabase.java
90 M C CSM: Shouldn't use synchronized method, please narrow down the synchronizati on scope. At JavaBridgeArrayCoercionTest.java 58 M C CSM: Shouldn't use synchronized method, please narrow down the synchronizati on scope. At JavaBridgeArrayCoercionTest.java
91 M C CSM: Shouldn't use synchronized method, please narrow down the synchronizati on scope. At JavaBridgeArrayTest.java 59 M C CSM: Shouldn't use synchronized method, please narrow down the synchronizati on scope. At JavaBridgeArrayTest.java
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_ERROR_BUTTON is n't final and can't be protected from malicious code In AppResource.java 187 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_ERROR_BUTTON is n't final and can't be protected from malicious code In AppResource.java
220 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_ERROR_TITLE isn 't final and can't be protected from malicious code In AppResource.java 188 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_ERROR_TITLE isn 't final and can't be protected from malicious code In AppResource.java
221 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_LOADING_VIDEO i sn't final and can't be protected from malicious code In AppResource.java 189 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_LOADING_VIDEO i sn't final and can't be protected from malicious code In AppResource.java
222 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_MESSAGE_PLAYBAC K_ERROR isn't final and can't be protected from malicious code In AppResource. java 190 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_MESSAGE_PLAYBAC K_ERROR isn't final and can't be protected from malicious code In AppResource. java
223 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_MESSAGE_UNKNOWN _ERROR isn't final and can't be protected from malicious code In AppResource.j ava 191 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_MESSAGE_UNKNOWN _ERROR isn't final and can't be protected from malicious code In AppResource.j ava
224 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_BROWSER_INITIATED_H TTP_POST should be package protected In LoadUrlParams.java 192 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_BROWSER_INITIATED_H TTP_POST should be package protected In LoadUrlParams.java
225 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DATA isn't final an d can't be protected from malicious code In LoadUrlParams.java 193 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DATA isn't final an d can't be protected from malicious code In LoadUrlParams.java
226 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DEFAULT should be p ackage protected In LoadUrlParams.java 194 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DEFAULT should be p ackage protected In LoadUrlParams.java
227 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_INHERIT should be package protected In LoadUrlParams.java 195 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_INHERIT should be package protected In LoadUrlParams.java
228 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE should be pa ckage protected In LoadUrlParams.java 196 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE should be pa ckage protected In LoadUrlParams.java
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698