Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 113631: Implement constructor and destructor of 64-bit assembler (Closed)

Created:
11 years, 7 months ago by William Hesse
Modified:
3 years, 10 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Implement constructor and destructor of 64-bit assembler Committed: http://code.google.com/p/v8/source/detail?r=2014

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -10 lines) Patch
M src/ia32/assembler-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +2 lines, -2 lines 2 comments Download
M src/x64/assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +87 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
Constructor is unchanged from ia32 version. Code size and offsets remain 32-bit (int).
11 years, 7 months ago (2009-05-20 10:34:16 UTC) #1
Lasse Reichstein
LGTM if you re-staticize the spare bugger. http://codereview.chromium.org/113631/diff/1/2 File src/ia32/assembler-ia32.cc (right): http://codereview.chromium.org/113631/diff/1/2#newcode291 Line 291: byte* ...
11 years, 7 months ago (2009-05-20 12:00:25 UTC) #2
William Hesse
11 years, 7 months ago (2009-05-20 16:14:30 UTC) #3
http://codereview.chromium.org/113631/diff/1/2
File src/ia32/assembler-ia32.cc (right):

http://codereview.chromium.org/113631/diff/1/2#newcode291
Line 291: byte* Assembler::spare_buffer_ = NULL;
On 2009/05/20 12:00:25, Lasse Reichstein wrote:
> I think this one should be static. It's for reusing a buffer between different
> assembler instances, to avoid allocating a new one every time.

The declaration in the class definition is static.  The definition does not need
the keyword static, and static means something different if it is used here
(file-scoped visibility).

Powered by Google App Engine
This is Rietveld 408576698