Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 11363045: [NaCl SDK] Beginnings of moving more stuff from build_sdk.py to GYP. (Closed)

Created:
8 years, 1 month ago by binji
Modified:
8 years, 1 month ago
Reviewers:
noelallen1
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK] Beginnings of moving more stuff from build_sdk.py to GYP. Adds a new target to all.gyp: chromium_builder_nacl_sdk Adds a native_client_sdk gyp file: it depends on nacl_core_sdk from the native_client repo, but also builds and copies ppapi libraries to the toolchain directories. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168359

Patch Set 1 #

Patch Set 2 : merge master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -0 lines) Patch
M build/all.gyp View 1 1 chunk +15 lines, -0 lines 0 comments Download
A native_client_sdk/src/build_tools/nacl_ppapi_sdk.gyp View 1 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
8 years, 1 month ago (2012-11-16 20:25:47 UTC) #1
noelallen1
lgtm
8 years, 1 month ago (2012-11-16 20:29:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/11363045/2001
8 years, 1 month ago (2012-11-16 20:33:16 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-16 21:05:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/11363045/2001
8 years, 1 month ago (2012-11-17 00:05:31 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-17 02:52:34 UTC) #6
Change committed as 168359

Powered by Google App Engine
This is Rietveld 408576698